fix(lighthouse-ci): run on every PR + nightly, drop label gate

HazAT · HazAT · commit 760b12880640 · 2026-05-13T09:11:32.000+02:00
Two changes that simplify the trigger surface and fix the HIGH-severity review-bot finding on PR #20850 about the workflow-level `labeled` trigger: 1. Remove `labeled` from `pull_request.types` in build.yml. With it included, adding ANY label to a PR (not just `ci:lighthouse`) re-triggered the whole workflow, and the workflow-level `concurrency.cancel-in-progress: true` block cancelled the in-progress build/test/e2e jobs and restarted them from scratch. Labels are no longer a CI control surface here. 2. Drop the `contains(labels, 'ci:lighthouse')` check on `job_lighthouse_matrix`. Lighthouse now runs on every PR push the same way the other test jobs do, plus on the nightly schedule. Simpler mental model, no per-PR opt-in. The Lighthouse jobs are still NOT referenced in `job_required_jobs_passed.needs`, so they never block merges \u2014 only surface measurements via the PR comment and (after the next commit) the workflow run Job Summary.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -8,7 +8,7 @@ on:
       - v8
       - release/**
   pull_request:
-    types: [opened, synchronize, reopened, labeled]
+    types: [opened, synchronize, reopened]
   merge_group:
     types: [checks_requested]
   workflow_dispatch:
@@ -1203,17 +1203,15 @@ jobs:
           if-no-files-found: ignore
 
   # -----------------------------------------------------------------------
-  # Lighthouse CI — nightly + label-gated (ci:lighthouse)
+  # Lighthouse CI — runs on every PR and on the nightly schedule.
   # NOT in job_required_jobs_passed — never blocks merges.
   # -----------------------------------------------------------------------
 
   job_lighthouse_matrix:
     name: Lighthouse Matrix
     needs: [job_get_metadata]
     runs-on: ubuntu-24.04
-    if: |
-      github.event_name == 'schedule' ||
-      (github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'ci:lighthouse'))
+    if: github.event_name == 'pull_request' || github.event_name == 'schedule'
     outputs:
       matrix: ${{ steps.matrix.outputs.matrix }}
     steps:
