perf(core): [SDK Overhead Reduction 10] Lazily create reflection JSON serializer#5601
Draft
adinauer wants to merge 1 commit into
Draft
Conversation
Defer creation of JsonReflectionObjectSerializer until unknown-object reflection serialization is needed. Normal SDK payloads use explicit serializers, so this avoids allocating unused reflection serializer state for each writer.
This was referenced Jun 23, 2026
Merged
📲 Install BuildsAndroid
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (SDK Overhead Reduction)
📜 Description
Lazily creates
JsonReflectionObjectSerializeronly when unknown-object reflection serialization is used.Known JSON serialization paths continue to serialize directly without creating the reflection serializer. Unknown-object fallback keeps using the same reflection serializer behavior once needed.
💡 Motivation and Context
Most SDK payloads serialize through explicit
JsonSerializableimplementations or other directly supported types. Those paths do not need reflection fallback, so eagerly allocatingJsonReflectionObjectSerializerfor every writer adds unnecessary overhead.💚 How did you test it?
./gradlew :sentry:test --tests io.sentry.JsonObjectSerializerTest./gradlew spotlessApply apiDump./gradlew :sentry:test --tests io.sentry.JsonObjectSerializerTest📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
#skip-changelog