try to run replay tests on gh emulators#5503
Draft
romtsn wants to merge 3 commits into
Draft
Conversation
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- try to run replay tests on gh emulators ([#5503](https://github.com/getsentry/sentry-java/pull/5503))If none of the above apply, you can opt out of this check by adding |
📲 Install BuildsAndroid
|
f6cc430 to
f48172d
Compare
Add an internal SentryReplayDebug.failFast switch (gated on the io.sentry.replay.compose.fail-fast system property) that re-throws the exceptions ComposeViewHierarchyNode normally swallows in fromComposeNode and fromView. Enabled in the sentry-samples-android app so our release/obfuscated builds running on real devices in CI crash instead of silently degrading masking. Defaults off, so customers are unaffected. Also guard the on-device ReplayTest against GitHub-hosted emulators, which can't capture screenshots reliably. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
f48172d to
b8d52cb
Compare
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 62b579c | 349.26 ms | 426.26 ms | 77.00 ms |
| d501a7e | 348.06 ms | 431.42 ms | 83.36 ms |
| cf708bd | 434.73 ms | 502.96 ms | 68.22 ms |
| 2195398 | 351.77 ms | 433.22 ms | 81.45 ms |
| cf708bd | 408.35 ms | 458.98 ms | 50.63 ms |
| e2dce0b | 308.96 ms | 360.10 ms | 51.14 ms |
| 5dee26b | 336.02 ms | 402.62 ms | 66.60 ms |
| 4c04bb8 | 333.16 ms | 408.16 ms | 75.00 ms |
| a1eadfa | 345.67 ms | 411.26 ms | 65.59 ms |
| 5b1a06b | 352.27 ms | 413.70 ms | 61.43 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 62b579c | 0 B | 0 B | 0 B |
| d501a7e | 0 B | 0 B | 0 B |
| cf708bd | 1.58 MiB | 2.11 MiB | 539.71 KiB |
| 2195398 | 0 B | 0 B | 0 B |
| cf708bd | 1.58 MiB | 2.11 MiB | 539.71 KiB |
| e2dce0b | 0 B | 0 B | 0 B |
| 5dee26b | 0 B | 0 B | 0 B |
| 4c04bb8 | 0 B | 0 B | 0 B |
| a1eadfa | 0 B | 0 B | 0 B |
| 5b1a06b | 0 B | 0 B | 0 B |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps