Skip to content

Commit f676e41

Browse files
author
John Haley
committed
Fixed build on windows
1 parent 3b315da commit f676e41

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

generate/descriptor.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -932,11 +932,17 @@
932932
},
933933
"remote_callbacks": {
934934
"fields": {
935+
"completion": {
936+
"ignore": true
937+
},
935938
"sideband_progress": {
936939
"ignore": true
937940
},
938941
"transfer_progress": {
939942
"ignore": true
943+
},
944+
"update_tips": {
945+
"ignore": true
940946
}
941947
}
942948
},

generate/partials/convert_from_v8.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@
2525
{%elsif cppClassName|isV8Value %}
2626

2727
{%if cType|isPointer %}
28-
*from_{{ name }} = ({{ cType|unPointer }}) {{ additionalCast }} {{ cast }} args[{{ jsArg }}]->To{{ cppClassName }}()->Value();
28+
*from_{{ name }} = ({{ cType|unPointer }}) {{ cast }} {%if isEnum %}(int){%endif%} args[{{ jsArg }}]->To{{ cppClassName }}()->Value();
2929
{%else%}
30-
from_{{ name }} = ({{ cType }}) {{ additionalCast }} {{ cast }} args[{{ jsArg }}]->To{{ cppClassName }}()->Value();
30+
from_{{ name }} = ({{ cType }}) {{ cast }} {%if isEnum %}(int){%endif%} args[{{ jsArg }}]->To{{ cppClassName }}()->Value();
3131
{%endif%}
3232
{%else%}
3333
{%if cType|isDoublePointer %}

0 commit comments

Comments
 (0)