Added an ignore file for things that are false-positives for missing tests

John Haley · John Haley · commit 9eb98514605a · 2014-11-12T17:23:38.000-07:00
diff --git a/generate/missing-tests-ignore.json b/generate/missing-tests-ignore.json
@@ -0,0 +1,34 @@
+{
+  "blob": {
+    "functions": [
+      "createFrombuffer",
+      "isBinary",
+      "lookup",
+      "rawcontent",
+      "rawsize"
+    ]
+  },
+  "clone": {
+    "functions": [
+      "initOptions"
+    ]
+  },
+  "commit": {
+    "functions": [
+      "parentCount",
+      "parentId",
+      "treeId"
+    ]
+  },
+  "diff": {
+    "functions": [
+      "getDelta",
+      "numDeltas"
+    ]
+  },
+  "object": {
+    "functions": [
+      "type"
+    ]
+  }
+}
diff --git a/generate/missing-tests.js b/generate/missing-tests.js
@@ -4,6 +4,7 @@ const Promise = require("nodegit-promise");
 const promisify = require("promisify-node");
 const fse = promisify(require("fs-extra"));
 const testFilesPath = path.resolve(__dirname, "../test/tests");
+const missingFileIgnores = require("./missing-tests-ignore");
 
 var output = {};
 
@@ -15,17 +16,25 @@ function findMissingTest(idef) {
   .then(function(file) {
     var fieldsResult = [];
     var functionsResult = [];
+    var fieldIgnores = (missingFileIgnores[idef.filename] || {}).fields;
+    var functionIgnores = (missingFileIgnores[idef.filename] || {}).functions;
+
+    fieldIgnores = fieldIgnores || [];
+    functionIgnores = functionIgnores || [];
+    file = file || "";
 
     idef.fields.forEach(function(field) {
-      if (file.indexOf(field.jsFunctionName) < 0) {
+      if (file.indexOf(field.jsFunctionName) < 0
+        && fieldIgnores.indexOf(field.jsFunctionName < 0)) {
         fieldsResult.push(field.jsFunctionName);
       }
     });
 
     result.fields = fieldsResult;
 
     idef.functions.forEach(function(fn) {
-      if (file.indexOf(fn.jsFunctionName) < 0) {
+      if (file.indexOf(fn.jsFunctionName) < 0
+        && functionIgnores.indexOf(fn.jsFunctionName) < 0) {
         functionsResult.push(fn.jsFunctionName);
       }
     });
@@ -50,4 +59,6 @@ Promise.all(promises)
 .then(function() {
   fse.writeFileSync(path.join(__dirname, "missing-tests.json"),
     JSON.stringify(output, null, 2));
+}, function(fail) {
+  console.log(fail);
 });
