Made cred callbacks async again

John Haley · John Haley · commit 81c14b751230 · 2014-11-11T15:54:41.000-07:00
diff --git a/generate/descriptor.json b/generate/descriptor.json
@@ -253,9 +253,6 @@
   "cred": {
     "cType": "git_cred",
     "functions": {
-      "git_cred_default_new":{
-        "isAsync": false
-      },
       "git_cred_ssh_custom_new": {
         "ignore": true
       },
@@ -265,14 +262,8 @@
       "git_cred_ssh_key_from_agent":{
         "isAsync": false
       },
-      "git_cred_ssh_key_new":{
-        "isAsync": false
-      },
       "git_cred_userpass": {
         "ignore": true
-      },
-      "git_cred_userpass_plaintext_new": {
-        "isAsync": false
       }
     }
   },
diff --git a/generate/partials/field_accessors.cc b/generate/partials/field_accessors.cc
@@ -133,11 +133,10 @@ void {{ cppClassName }}::{{ field.name }}_asyncAfter(uv_work_t* req, int status)
   TryCatch tryCatch;
   Handle<Value> result = instance->{{ field.name }}->Call({{ field.args|jsArgsCount }}, argv);
 
-  if (result->IsObject()) {
-    const char* constructorName = **(new NanUtf8String(result->ToObject()->GetConstructorName()));
-    string promiseConName ("Promise");
+  if (result->IsObject() && result->ToObject()->Has(NanNew("then"))) {
+    Handle<Value> thenProp = result->ToObject()->Get(NanNew("then"));
 
-    if (promiseConName.compare(constructorName) == 0) {
+    if (thenProp->IsFunction()) {
       // we can be reasonbly certain that the result is a promise
       Local<Object> promise = result->ToObject();
 
