Fix an issue w/ cleaning up global.document.

gdborton · gdborton · commit cc05b8a44732 · 2017-03-22T18:00:59.000-07:00
Except in the most recent versions of node, developers are unable to delete things from global when running code in a node vm. This means that enzyme is failing to clean up after itself when temporarily defining global.document for setState calls. This papers over the issue by explicitly setting global.document to undefined if it failed to be deleted. Relevant jest issue - jestjs/jest#3152 Relevant node pr - nodejs/node#11266
diff --git a/src/Utils.js b/src/Utils.js
@@ -222,6 +222,11 @@ export function withSetStateAllowed(fn) {
   fn();
   if (cleanup) {
     delete global.document;
+    // This works around a bug in node/jest in that developers aren't able to
+    // delete things from global when running in a node vm.
+    if (global.document) {
+      global.document = undefined;
+    }
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -222,6 +222,11 @@ export function withSetStateAllowed(fn) {`
`222`	`222`	`fn();`
`223`	`223`	`if (cleanup) {`
`224`	`224`	`delete global.document;`
	`225`	`+ // This works around a bug in node/jest in that developers aren't able to`
	`226`	`+ // delete things from global when running in a node vm.`
	`227`	`+ if (global.document) {`
	`228`	`+ global.document = undefined;`
	`229`	`+ }`
`225`	`230`	`}`
`226`	`231`	`}`
`227`	`232`