Fix an issue w/ cleaning up global.document.

gdborton · gdborton · commit 963426961159 · 2017-03-23T17:31:11.000-07:00
Except in the most recent versions of node, developers are unable to delete things from global when running code in a node vm. This means that enzyme is failing to clean up after itself when temporarily defining global.document for setState calls. This papers over the issue by explicitly setting global.document to undefined before attempting to delete. If the delete succeeds, the undefined value will be removed. Relevant jest issue - jestjs/jest#3152 Relevant node pr - nodejs/node#11266
diff --git a/src/Utils.js b/src/Utils.js
@@ -221,6 +221,9 @@ export function withSetStateAllowed(fn) {
   }
   fn();
   if (cleanup) {
+    // This works around a bug in node/jest in that developers aren't able to
+    // delete things from global when running in a node vm.
+    global.document = undefined;
     delete global.document;
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -221,6 +221,9 @@ export function withSetStateAllowed(fn) {`
`221`	`221`	`}`
`222`	`222`	`fn();`
`223`	`223`	`if (cleanup) {`
	`224`	`+ // This works around a bug in node/jest in that developers aren't able to`
	`225`	`+ // delete things from global when running in a node vm.`
	`226`	`+ global.document = undefined;`
`224`	`227`	`delete global.document;`
`225`	`228`	`}`
`226`	`229`	`}`