Skip to content

fix: recognize BREAKING-CHANGE trailers#40

Merged
gbprod merged 1 commit into
gbprod:mainfrom
SKalt:recognize-BREAKING-CHANGE
May 19, 2023
Merged

fix: recognize BREAKING-CHANGE trailers#40
gbprod merged 1 commit into
gbprod:mainfrom
SKalt:recognize-BREAKING-CHANGE

Conversation

@SKalt

@SKalt SKalt commented May 17, 2023

Copy link
Copy Markdown
Contributor
  1. BREAKING-CHANGE MUST be synonymous with BREAKING CHANGE, when used as a token in a footer.
    -- https://www.conventionalcommits.org/en/v1.0.0/#specification

Fixes #39

> 16. `BREAKING-CHANGE` MUST be synonymous with `BREAKING CHANGE`, when used as a token in a footer.
> -- https://www.conventionalcommits.org/en/v1.0.0/#specification

Fixes gbprod#39
@SKalt SKalt force-pushed the recognize-BREAKING-CHANGE branch from 3d2e2cd to 66eb7f2 Compare May 18, 2023 14:08
@SKalt

SKalt commented May 18, 2023

Copy link
Copy Markdown
Contributor Author

Shoot, sorry -- I forgot this project requires committing the generated code in src/{grammar.json,parser.c}. Omitting those changes caused the CI run to fail.

@gbprod

gbprod commented May 19, 2023

Copy link
Copy Markdown
Owner

👌

@gbprod gbprod merged commit 9d8c81e into gbprod:main May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

recognize BREAKING-CHANGE per the conventional commit spec

2 participants