Skip to content

Commit 54d1cb3

Browse files
keithbrandjon
keith
authored and
brandjon
committed
Pass --isolated to pip (bazel-contrib#232)
This fixes an issue where if you have bad URLs in your ~/.pip/pip.conf, pip would pick them up and end up failing bazel. This way we make pip_import more hermetic and ignore user config.
1 parent e064496 commit 54d1cb3

2 files changed

Lines changed: 1 addition & 1 deletion

File tree

‎packaging/piptool.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ def pip_main(argv):
7878
atexit.register(lambda: shutil.rmtree(cert_tmpdir, ignore_errors=True))
7979
with open(cert_path, "wb") as cert:
8080
cert.write(pkgutil.get_data("pip._vendor.requests", "cacert.pem"))
81-
argv = ["--disable-pip-version-check", "--cert", cert_path] + argv
81+
argv = ["--isolated", "--disable-pip-version-check", "--cert", cert_path] + argv
8282
return pip.main(argv)
8383

8484
from packaging.whl import Wheel

‎tools/piptool.par‎

28 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)