From 1bb00f18fb5cc73318a959eab61d4c742228e06b Mon Sep 17 00:00:00 2001 From: JB Giraudeau Date: Tue, 19 May 2015 20:59:31 +0200 Subject: [PATCH 1/2] Fixed #133 Effect.f(Effect0) now does not ignore its argument --- core/src/main/java/fj/Effect.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/core/src/main/java/fj/Effect.java b/core/src/main/java/fj/Effect.java index 884e7399..f7df707b 100644 --- a/core/src/main/java/fj/Effect.java +++ b/core/src/main/java/fj/Effect.java @@ -22,7 +22,10 @@ public class Effect { private Effect() {} public static P1 f(Effect0 e) { - return P.lazy(u -> unit()); + return P.lazy(() -> { + e.f(); + return unit(); + }); } /** From 35cdd652518ceccf1adbe6bb0ca9f9a631f1690e Mon Sep 17 00:00:00 2001 From: JB Giraudeau Date: Tue, 19 May 2015 21:29:20 +0200 Subject: [PATCH 2/2] Fixed #135: make Effect.comap static --- core/src/main/java/fj/Effect.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/main/java/fj/Effect.java b/core/src/main/java/fj/Effect.java index f7df707b..ef4cd547 100644 --- a/core/src/main/java/fj/Effect.java +++ b/core/src/main/java/fj/Effect.java @@ -95,7 +95,7 @@ public static F5 f(Effect5 z * @param f The function to map over the effect. * @return An effect after a contra-variant map. */ - public final Effect1 comap(Effect1 e1, final F f) { + public static final Effect1 comap(Effect1 e1, final F f) { return b -> e1.f(f.f(b)); }