Java8 converter: Do not silently convert Option.some(null) to Optional.absent()

jbgi · jbgi · commit a8f9db4320e7 · 2016-10-23T11:34:17.000+02:00
Let's not try to cover for Optional mistakes. Otherwise bugs will silently happen.
diff --git a/java8/src/main/java/fj/data/Java8.java b/java8/src/main/java/fj/data/Java8.java
@@ -112,8 +112,11 @@ public static <A> F<Optional<A>, Option<A>> Optional_Option() {
         return Java8::Optional_Option;
     }
 
+    /**
+     * Convert an Option to {@link Optional}. Will throw a {@link NullPointerException} if the Option is some(null).
+     */
     public static <A> Optional<A> Option_Optional(final Option<A> o) {
-        return o.option(Optional.empty(), Optional::ofNullable);
+        return o.option(Optional.empty(), Optional::of);
     }
 
     public static <A> F<Option<A>, Optional<A>> Option_Optional() {

Original file line number	Diff line number	Diff line change
`@@ -112,8 +112,11 @@ public static <A> F<Optional<A>, Option<A>> Optional_Option() {`
`112`	`112`	`return Java8::Optional_Option;`
`113`	`113`	`}`
`114`	`114`
	`115`	`+ /**`
	`116`	`+ * Convert an Option to {@link Optional}. Will throw a {@link NullPointerException} if the Option is some(null).`
	`117`	`+ */`
`115`	`118`	`public static <A> Optional<A> Option_Optional(final Option<A> o) {`
`116`		`- return o.option(Optional.empty(), Optional::ofNullable);`
	`119`	`+ return o.option(Optional.empty(), Optional::of);`
`117`	`120`	`}`
`118`	`121`
`119`	`122`	`public static <A> F<Option<A>, Optional<A>> Option_Optional() {`