Fixed a bug in the NonEmptyList Semigroup implementation that resulted in the same NonEmptyList appended to itself.

bakeemawaytoys · jbgi · commit 07f94fa172d9 · 2017-05-10T21:55:58.000+02:00
diff --git a/core/src/main/java/fj/Semigroup.java b/core/src/main/java/fj/Semigroup.java
@@ -534,7 +534,7 @@ public static <A> Semigroup<NonEmptyList<A>> nonEmptyListSemigroup() {
     return semigroupDef(new Definition<NonEmptyList<A>>() {
       @Override
       public NonEmptyList<A> append(NonEmptyList<A> a1, NonEmptyList<A> a2) {
-        return a1.append(a1);
+        return a1.append(a2);
       }
 
       @Override

Original file line number	Diff line number	Diff line change
`@@ -534,7 +534,7 @@ public static <A> Semigroup<NonEmptyList<A>> nonEmptyListSemigroup() {`
`534`	`534`	`return semigroupDef(new Definition<NonEmptyList<A>>() {`
`535`	`535`	`@Override`
`536`	`536`	`public NonEmptyList<A> append(NonEmptyList<A> a1, NonEmptyList<A> a2) {`
`537`		`- return a1.append(a1);`
	`537`	`+ return a1.append(a2);`
`538`	`538`	`}`
`539`	`539`
`540`	`540`	`@Override`