Avoid the class declaration not found assert when the new expression doesnt contain construct signature

sheetalkamat · sheetalkamat · commit dab0dbe6f04d · 2018-02-07T13:30:58.000-08:00
diff --git a/src/services/goToDefinition.ts b/src/services/goToDefinition.ts
@@ -191,7 +191,7 @@ namespace ts.GoToDefinition {
         function getConstructSignatureDefinition(): DefinitionInfo[] | undefined {
             // Applicable only if we are in a new expression, or we are on a constructor declaration
             // and in either case the symbol has a construct signature definition, i.e. class
-            if (isNewExpressionTarget(node) || node.kind === SyntaxKind.ConstructorKeyword && symbol.flags & SymbolFlags.Class) {
+            if (symbol.flags & SymbolFlags.Class && (isNewExpressionTarget(node) || node.kind === SyntaxKind.ConstructorKeyword)) {
                 const cls = find(symbol.declarations, isClassLike) || Debug.fail("Expected declaration to have at least one class-like declaration");
                 return getSignatureDefinition(cls.members, /*selectConstructors*/ true);
             }
diff --git a/tests/cases/fourslash/goToDefinitionNewExpressionTargetNotClass.ts b/tests/cases/fourslash/goToDefinitionNewExpressionTargetNotClass.ts
@@ -5,6 +5,12 @@
 ////let I: {
 ////    /*constructSignature*/new(): C2;
 ////};
-////let C = new [|/*invokeExpression*/I|]();
+////new [|/*invokeExpression1*/I|]();
+////let /*symbolDeclaration*/I2: {
+////};
+////new [|/*invokeExpression2*/I2|]();
 
-verify.goToDefinition("invokeExpression", "constructSignature");
+verify.goToDefinition({
+    invokeExpression1: "constructSignature",
+    invokeExpression2: "symbolDeclaration"
+});

Original file line number	Diff line number	Diff line change
`@@ -191,7 +191,7 @@ namespace ts.GoToDefinition {`
`191`	`191`	`function getConstructSignatureDefinition(): DefinitionInfo[] \| undefined {`
`192`	`192`	`// Applicable only if we are in a new expression, or we are on a constructor declaration`
`193`	`193`	`// and in either case the symbol has a construct signature definition, i.e. class`
`194`		`- if (isNewExpressionTarget(node) \|\| node.kind === SyntaxKind.ConstructorKeyword && symbol.flags & SymbolFlags.Class) {`
	`194`	`+ if (symbol.flags & SymbolFlags.Class && (isNewExpressionTarget(node) \|\| node.kind === SyntaxKind.ConstructorKeyword)) {`
`195`	`195`	`const cls = find(symbol.declarations, isClassLike) \|\| Debug.fail("Expected declaration to have at least one class-like declaration");`
`196`	`196`	`return getSignatureDefinition(cls.members, /selectConstructors/ true);`
`197`	`197`	`}`