feat: keep main module in py_library (bazel-contrib#1608)

linzhp · web-flow · commit e7d5c8db6dcc · 2023-12-14T00:24:52.000Z
Unlike Go, the main module of Python can still be imported by other
modules. We should keep them in the `py_library` target to allow such
imports.
diff --git a/gazelle/python/generate.go b/gazelle/python/generate.go
@@ -248,7 +248,6 @@ func (py *Python) GenerateRules(args language.GenerateArgs) language.GenerateRes
 						fqTarget.String(), actualPyBinaryKind, err)
 					continue
 				}
-				srcs.Remove(filename)
 				pyBinary := newTargetBuilder(pyBinaryKind, pyBinaryTargetName, pythonProjectRoot, args.Rel, pyFileNames).
 					addVisibility(visibility).
 					addSrc(filename).
diff --git a/gazelle/python/testdata/binary_without_entrypoint/BUILD.out b/gazelle/python/testdata/binary_without_entrypoint/BUILD.out
@@ -24,6 +24,8 @@ py_library(
     srcs = [
         "__init__.py",
         "collided_main.py",
+        "main.py",
+        "main2.py",
     ],
     visibility = ["//:__subpackages__"],
 )

Original file line number	Diff line number	Diff line change
`@@ -248,7 +248,6 @@ func (py *Python) GenerateRules(args language.GenerateArgs) language.GenerateRes`
`248`	`248`	`fqTarget.String(), actualPyBinaryKind, err)`
`249`	`249`	`continue`
`250`	`250`	`}`
`251`		`- srcs.Remove(filename)`
`252`	`251`	`pyBinary := newTargetBuilder(pyBinaryKind, pyBinaryTargetName, pythonProjectRoot, args.Rel, pyFileNames).`
`253`	`252`	`addVisibility(visibility).`
`254`	`253`	`addSrc(filename).`