buggie fix maybe?

pgbovine · pgbovine · commit e23586735091 · 2016-05-29T02:06:38.000-04:00
diff --git a/v3/codeopticon/js/codeopticon-learner.js b/v3/codeopticon/js/codeopticon-learner.js
@@ -7,10 +7,6 @@
 
 /* TODOs:
 
-- look into whether logEventQueue is being popped in the right order or
-  whether it's being popped backwards; if so, that's bad because that
-  causes events to be emitted out of order, eeek!
-
 */
 
 var codeopticonSocketIO = undefined; // socket.io instance
@@ -96,7 +92,7 @@ function initCodeopticon() {
         }
 
         while (logEventQueue.length > 0) {
-          codeopticonSocketIO.emit('opt-client-event', logEventQueue.pop());
+          codeopticonSocketIO.emit('opt-client-event', logEventQueue.shift() /* FIFO */);
         }
       }
       assert(logEventQueue.length === 0);

Original file line number	Diff line number	Diff line change
`@@ -7,10 +7,6 @@`
`7`	`7`
`8`	`8`	`/* TODOs:`
`9`	`9`
`10`		`-- look into whether logEventQueue is being popped in the right order or`
`11`		`- whether it's being popped backwards; if so, that's bad because that`
`12`		`- causes events to be emitted out of order, eeek!`
`13`		`-`
`14`	`10`	`*/`
`15`	`11`
`16`	`12`	`var codeopticonSocketIO = undefined; // socket.io instance`
`@@ -96,7 +92,7 @@ function initCodeopticon() {`
`96`	`92`	`}`
`97`	`93`
`98`	`94`	`while (logEventQueue.length > 0) {`
`99`		`- codeopticonSocketIO.emit('opt-client-event', logEventQueue.pop());`
	`95`	`+ codeopticonSocketIO.emit('opt-client-event', logEventQueue.shift() /* FIFO */);`
`100`	`96`	`}`
`101`	`97`	`}`
`102`	`98`	`assert(logEventQueue.length === 0);`