Fix pointers equality in TypeDefinitionsEquivalent function (oapi-codegen#952)

spinillos · Marcin Romaszewicz · web-flow · commit 700d8499cbff · 2023-05-05T14:02:14.000-07:00
Co-authored-by: Marcin Romaszewicz &lt;47459980+deepmap-marcinr@users.noreply.github.com&gt;
diff --git a/pkg/codegen/utils.go b/pkg/codegen/utils.go
@@ -17,6 +17,7 @@ import (
 	"fmt"
 	"go/token"
 	"net/url"
+	"reflect"
 	"regexp"
 	"sort"
 	"strconv"
@@ -922,5 +923,5 @@ func TypeDefinitionsEquivalent(t1, t2 TypeDefinition) bool {
 	if t1.TypeName != t2.TypeName {
 		return false
 	}
-	return t1.Schema.OAPISchema == t2.Schema.OAPISchema
+	return reflect.DeepEqual(t1.Schema.OAPISchema, t2.Schema.OAPISchema)
 }
diff --git a/pkg/codegen/utils_test.go b/pkg/codegen/utils_test.go
@@ -433,6 +433,18 @@ func TestSchemaNameToTypeName(t *testing.T) {
 	}
 }
 
+
+func TestTypeDefinitionsEquivalent(t *testing.T) {
+	def1 := TypeDefinition{TypeName: "name", Schema: Schema{
+		OAPISchema: &openapi3.Schema{},
+	}}
+	def2 := TypeDefinition{TypeName: "name", Schema: Schema{
+		OAPISchema: &openapi3.Schema{},
+	}}
+	assert.True(t, TypeDefinitionsEquivalent(def1, def2))
+}
+
+
 func TestRefPathToObjName(t *testing.T) {
 	t.Parallel()
 

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,7 @@ import (`
`17`	`17`	`"fmt"`
`18`	`18`	`"go/token"`
`19`	`19`	`"net/url"`
	`20`	`+ "reflect"`
`20`	`21`	`"regexp"`
`21`	`22`	`"sort"`
`22`	`23`	`"strconv"`
`@@ -922,5 +923,5 @@ func TypeDefinitionsEquivalent(t1, t2 TypeDefinition) bool {`
`922`	`923`	`if t1.TypeName != t2.TypeName {`
`923`	`924`	`return false`
`924`	`925`	`}`
`925`		`- return t1.Schema.OAPISchema == t2.Schema.OAPISchema`
	`926`	`+ return reflect.DeepEqual(t1.Schema.OAPISchema, t2.Schema.OAPISchema)`
`926`	`927`	`}`