Week1#7
Closed
chichiglacierz wants to merge 5 commits into
Closed
Conversation
mattiaslundberg
requested changes
Aug 31, 2019
Collaborator
mattiaslundberg
left a comment
There was a problem hiding this comment.
Missing two things (other comments are nice to have/fix later but optional):
- Create the link (there are some pointers in the comment)
- Load repo information when the page loads (let me know if you need more pointers for this!)
| createAndAppend('pre', root, { text: JSON.stringify(data, null, 2) }); | ||
| //createAndAppend('pre', root, { text: JSON.stringify(data, null, 2) }); | ||
| const header = createAndAppend('header', root, { class: 'header' }); | ||
| const h1 = createAndAppend('h1', header, { text: 'FooCoding Repos', class: 'h1' }); |
Collaborator
There was a problem hiding this comment.
Nice usage of createAndAppend!
| const h1 = createAndAppend('h1', header, { text: 'FooCoding Repos', class: 'h1' }); | ||
|
|
||
| const select = createAndAppend('select', root, { class: 'select' }); | ||
| createAndAppend('option', select, { text: 'Choose your favorite repo below:' }); |
Collaborator
There was a problem hiding this comment.
One of the requirements is that information for the first repo is shown when the page loads, can you have a look at that?
| data.forEach(repo => { | ||
| const name = repo.name; | ||
| createAndAppend('option', select, { text: name }); | ||
| //console.log(name); |
Collaborator
There was a problem hiding this comment.
Don't leave commented out code, remove it! It's easier for me to review and easier for you to read when you come back to it at a later time.
| addInfo('Description: ', repo.description); | ||
| addInfo('Number of forks: ', repo.forks); | ||
| addInfo('Updated: ', repo.updated_at); | ||
| //or instead of using the addInfo function we can use these lines: |
Collaborator
There was a problem hiding this comment.
To create a link:
createAndAppend('a', repoInfo, {text: label, href: url})
| } | ||
| contribData.forEach(contributor => { | ||
| createAndAppend('div', contribs, { text: contributor.login }); | ||
| //createAndAppend('a', contribs, { href: contributor.html.url, setAttribute: 'href' }); |
Collaborator
There was a problem hiding this comment.
I think the issues here are:
contributor.html.urlshould becontributor.html_url- you need to add
text: contributor.login
Author
There was a problem hiding this comment.
So that's why it wasn't working. Thanks!
| contribData.forEach(contributor => { | ||
| createAndAppend('div', contribs, { text: contributor.login }); | ||
| //createAndAppend('a', contribs, { href: contributor.html.url, setAttribute: 'href' }); | ||
| createAndAppend('img', contribs, { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.