setup: Fixed error when passing shell reserved characters to setup databases (apache#4995)

Spaceman1984 · web-flow · commit 7a7fd2735039 · 2021-05-04T23:09:19.000+05:30
* Fixed error when passing shell reserved charaters to setup databases script for dbsecret

* Moved quote to encrypt method
diff --git a/setup/bindir/cloud-setup-databases.in b/setup/bindir/cloud-setup-databases.in
@@ -26,6 +26,7 @@ import string
 from optparse import OptionParser
 import subprocess
 import shutil
+import shlex
 import socket
 
 # squelch mysqldb spurious warnings
@@ -399,7 +400,7 @@ for example:
             return 'ENC(%s)'%value
 
         def encryptDBSecretKey():
-            self.putDbProperty('db.cloud.encrypt.secret', formatEncryptResult(encrypt(self.dbsecretkey)))
+            self.putDbProperty('db.cloud.encrypt.secret', formatEncryptResult(encrypt(shlex.quote(self.dbsecretkey))))
 
         def encryptDBPassword():
             dbPassword = self.getDbProperty('db.cloud.password')
