Fix converter bug

copitux · copitux · commit 61dabfbe621a · 2011-11-14T00:29:46.000+01:00
diff --git a/github3/converters.py b/github3/converters.py
@@ -52,7 +52,8 @@ def inject(self, model):
         self.model = model
 
     def _parse_map(self, model, raw_resource):
-        return Modelizer(model).loads(raw_resource)
+        if getattr(raw_resource, 'items', False):
+            return Modelizer(model).loads(raw_resource)
 
     def _parse_collection_map(self, model, raw_resources):
         # Dict of resources (Ex: Gist file)
@@ -62,7 +63,7 @@ def _parse_collection_map(self, model, raw_resources):
                 dict_map[key] = Modelizer(model).loads(raw_resource)
             return dict_map
         # list of resources
-        else:
+        elif getattr(raw_resources, '__iter__', False):
             return [Modelizer(model).loads(raw_resource)
                     for raw_resource in raw_resources]
 
diff --git a/github3/tests/converters_test.py b/github3/tests/converters_test.py
@@ -23,7 +23,8 @@
     'list_map': [
         {'test_str': 'string', 'test_int': 1},
         {'test_str': 'string', 'test_int': 2},
-    ]
+    ],
+    'fake_map': 9,
 }
 
 
@@ -36,10 +37,11 @@ def idl(self):
             'ints': ['test_int'],
             'dates': ['test_date'],
             'bools': ['test_bool'],
-            'maps': {'map': Model},
+            'maps': {'map': Model, 'fake_map': Model},
             'collection_maps': {
                 'dict_map': Model,
                 'list_map': Model,
+                'fake_map': Model,
             },
         }
 
