Clarify BackdropFilter does not affect native platform views#186367
Draft
mboetger wants to merge 1 commit into
Draft
Clarify BackdropFilter does not affect native platform views#186367mboetger wants to merge 1 commit into
mboetger wants to merge 1 commit into
Conversation
…native platform views
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds documentation to clarify that the BackdropFilter widget only filters content rendered by Flutter and does not affect native platform views. The review feedback recommends enhancing this documentation by linking to specific platform view widgets and using standard terminology to align with the repository's style guide.
Comment on lines
+495
to
+497
| /// This widget only filters content rendered by Flutter. It does not affect | ||
| /// native platform views (like Android views or iOS views) because those views | ||
| /// are rendered by the platform itself, not by Flutter's engine. |
Contributor
There was a problem hiding this comment.
To adhere to the Flutter style guide, consider linking to the definitions of the terms introduced. Using specific widget references like [AndroidView] and [UiKitView] provides better context for 'platform views'. Additionally, 'the Flutter engine' is the standard terminology used in the documentation.
/// This widget only filters content rendered by Flutter. It does not affect
/// platform views (such as [AndroidView] or [UiKitView]) because those views
/// are rendered by the platform itself, not by the Flutter engine.References
- Introduce terms: Assume the reader does not know everything. Link to definitions. (link)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update dart documentation to clarify filtering rules only affect Flutter views.
Fixes: #132089
Pre-launch Checklist
///).