From 2741a6cbbaa46c18d6d332ed0a5cdc86b980509b Mon Sep 17 00:00:00 2001 From: Momshad Dinury Date: Sat, 18 Apr 2026 14:20:11 +0600 Subject: [PATCH] Remove unnecessary Material import from editable_text_scribe_test This test is located in the Widgets layer and did not need to import package:flutter/material.dart. Replace the MaterialApp wrapper with TestWidgetsApp (from widgets_app_tester.dart), swap Colors.grey for its raw color value, and use emptyTextSelectionControls in place of materialTextSelectionControls. Part of https://github.com/flutter/flutter/issues/177028 --- dev/bots/check_tests_cross_imports.dart | 1 - .../test/widgets/editable_text_scribe_test.dart | 10 ++++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/dev/bots/check_tests_cross_imports.dart b/dev/bots/check_tests_cross_imports.dart index b019dbaec3e9a..2706f15c1763f 100644 --- a/dev/bots/check_tests_cross_imports.dart +++ b/dev/bots/check_tests_cross_imports.dart @@ -113,7 +113,6 @@ class TestsCrossImportChecker { 'packages/flutter/test/widgets/editable_text_scribble_test.dart', 'packages/flutter/test/widgets/range_maintaining_scroll_physics_test.dart', 'packages/flutter/test/widgets/selectable_region_test.dart', - 'packages/flutter/test/widgets/editable_text_scribe_test.dart', 'packages/flutter/test/widgets/semantics_debugger_test.dart', 'packages/flutter/test/widgets/page_route_builder_test.dart', 'packages/flutter/test/widgets/two_dimensional_scroll_view_test.dart', diff --git a/packages/flutter/test/widgets/editable_text_scribe_test.dart b/packages/flutter/test/widgets/editable_text_scribe_test.dart index 85104e39da477..521134f478714 100644 --- a/packages/flutter/test/widgets/editable_text_scribe_test.dart +++ b/packages/flutter/test/widgets/editable_text_scribe_test.dart @@ -5,10 +5,12 @@ import 'dart:ui' show PointerDeviceKind; import 'package:flutter/foundation.dart'; -import 'package:flutter/material.dart'; import 'package:flutter/services.dart'; +import 'package:flutter/widgets.dart'; import 'package:flutter_test/flutter_test.dart'; +import 'widgets_app_tester.dart'; + void main() { final TestWidgetsFlutterBinding binding = TestWidgetsFlutterBinding.ensureInitialized(); @@ -58,17 +60,17 @@ void main() { final provider = TextSelectionGestureDetectorBuilder(delegate: delegate); await tester.pumpWidget( - MaterialApp( + TestWidgetsApp( home: provider.buildGestureDetector( behavior: HitTestBehavior.translucent, child: EditableText( key: editableTextKey, controller: controller, - backgroundCursorColor: Colors.grey, + backgroundCursorColor: const Color(0xFF9E9E9E), focusNode: focusNode, style: textStyle, cursorColor: cursorColor, - selectionControls: materialTextSelectionControls, + selectionControls: emptyTextSelectionControls, showSelectionHandles: true, ), ),