From 43ba30e3d2d2753f2f8c45b1ccbd5b0123982f32 Mon Sep 17 00:00:00 2001 From: abdessalem Date: Fri, 20 Feb 2026 09:27:44 +0100 Subject: [PATCH 1/2] replace more references to flutter/engine with flutter/flutter --- dev/devicelab/bin/tasks/hello_world_impeller.dart | 2 +- docs/engine/impeller/Flutter-GPU.md | 2 +- docs/platforms/android/Texture-Layer-Hybrid-Composition.md | 2 +- engine/src/flutter/tools/gradle/README.md | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dev/devicelab/bin/tasks/hello_world_impeller.dart b/dev/devicelab/bin/tasks/hello_world_impeller.dart index 2486de38b9788..7bfcaeaf4e38c 100644 --- a/dev/devicelab/bin/tasks/hello_world_impeller.dart +++ b/dev/devicelab/bin/tasks/hello_world_impeller.dart @@ -43,7 +43,7 @@ Future run() async { isUsingValidationLayers = true; } // "ImpellerValidationBreak" comes from the engine: - // https://github.com/flutter/engine/blob/4160ebacdae2081d6f3160432f5f0dd87dbebec1/impeller/base/validation.cc#L40 + // https://github.com/flutter/flutter/blob/91b2d41a66d1c540233b819525553afc0fa1f58d/engine/src/flutter/impeller/base/validation.cc#L54 if (data.contains('ImpellerValidationBreak')) { hasValidationErrors = true; } diff --git a/docs/engine/impeller/Flutter-GPU.md b/docs/engine/impeller/Flutter-GPU.md index dc0d1e8f771ba..33937d48020a7 100644 --- a/docs/engine/impeller/Flutter-GPU.md +++ b/docs/engine/impeller/Flutter-GPU.md @@ -32,7 +32,7 @@ dependencies: - [Project dashboard](https://github.com/orgs/flutter/projects/134/views/1) - [Original design doc](https://flutter.dev/go/impeller-dart) (now outdated!) -- [flutter_gpu package source](https://github.com/flutter/engine/tree/main/lib/gpu) +- [flutter_gpu package source](https://github.com/flutter/flutter/tree/main/engine/src/flutter/lib/gpu) ## Dart FFI diff --git a/docs/platforms/android/Texture-Layer-Hybrid-Composition.md b/docs/platforms/android/Texture-Layer-Hybrid-Composition.md index 670494ac07c45..92191772f3cc4 100644 --- a/docs/platforms/android/Texture-Layer-Hybrid-Composition.md +++ b/docs/platforms/android/Texture-Layer-Hybrid-Composition.md @@ -8,7 +8,7 @@ It was introduced in Flutter 3.0 to combine the best aspects of Virtual Display # Approach -TLHC uses a [custom `FrameLayout`](https://github.com/flutter/engine/blob/7025645c52bfaeb1cc67be5ca842b65772c89c8e/shell/platform/android/io/flutter/plugin/platform/PlatformViewWrapper.java#L35-L46), which is placed in the native view hierarchy as normal, but [redirects drawing](https://github.com/flutter/engine/blob/7025645c52bfaeb1cc67be5ca842b65772c89c8e/shell/platform/android/io/flutter/plugin/platform/PlatformViewWrapper.java#L299-L309) to a canvas that backs a Flutter [`Texture`](https://api.flutter.dev/flutter/widgets/Texture-class.html) in order to compose with the rest of the Flutter UI as normal (without the layering and threading complexities of Hybrid Composition). +TLHC uses a [custom `FrameLayout`](https://github.com/flutter/flutter/blob/91b2d41a66d1c540233b819525553afc0fa1f58d/engine/src/flutter/shell/platform/android/io/flutter/plugin/platform/PlatformViewWrapper.java#L29-L39), which is placed in the native view hierarchy as normal, but [redirects drawing](https://github.com/flutter/flutter/blob/91b2d41a66d1c540233b819525553afc0fa1f58d/engine/src/flutter/shell/platform/android/io/flutter/plugin/platform/PlatformViewWrapper.java#L178-L187) to a canvas that backs a Flutter [`Texture`](https://api.flutter.dev/flutter/widgets/Texture-class.html) in order to compose with the rest of the Flutter UI as normal (without the layering and threading complexities of Hybrid Composition). # Limitations diff --git a/engine/src/flutter/tools/gradle/README.md b/engine/src/flutter/tools/gradle/README.md index 54207a11719ec..fb539f01b6d19 100644 --- a/engine/src/flutter/tools/gradle/README.md +++ b/engine/src/flutter/tools/gradle/README.md @@ -30,7 +30,7 @@ Gradle version that you downloaded and verified. 1. Authenticate with CIPD by running `cipd auth-login`. 2. Run `cipd create -in gradle-7.5.1 -install-mode copy -tag version:7.5.1 -name flutter/gradle` to upload the new Gradle version to CIPD. -3. Update the `engine/src/flutter/DEPS` Gradle entry (which should look something like [this](https://github.com/flutter/engine/blob/4caaab9f2502481b606b930abeea4a361022fa16/DEPS#L732-L743)) +3. Update the `engine/src/flutter/DEPS` Gradle entry (which should look something like [this](https://github.com/flutter/flutter/blob/91b2d41a66d1c540233b819525553afc0fa1f58d/DEPS#L573)) to contain the tag from the command above (version:7.5.1). 4. Run `gclient sync` to verify that the dependency can be fetched. From 66e739056bc0f3eec626d1397db4bc26b8357c70 Mon Sep 17 00:00:00 2001 From: Mohellebi Abdessalem <116356835+AbdeMohlbi@users.noreply.github.com> Date: Sat, 21 Feb 2026 16:37:07 +0100 Subject: [PATCH 2/2] gemini has a point Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --- engine/src/flutter/tools/gradle/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/engine/src/flutter/tools/gradle/README.md b/engine/src/flutter/tools/gradle/README.md index fb539f01b6d19..9001892bef3b7 100644 --- a/engine/src/flutter/tools/gradle/README.md +++ b/engine/src/flutter/tools/gradle/README.md @@ -30,7 +30,7 @@ Gradle version that you downloaded and verified. 1. Authenticate with CIPD by running `cipd auth-login`. 2. Run `cipd create -in gradle-7.5.1 -install-mode copy -tag version:7.5.1 -name flutter/gradle` to upload the new Gradle version to CIPD. -3. Update the `engine/src/flutter/DEPS` Gradle entry (which should look something like [this](https://github.com/flutter/flutter/blob/91b2d41a66d1c540233b819525553afc0fa1f58d/DEPS#L573)) +3. Update the `DEPS` Gradle entry (which should look something like [this](https://github.com/flutter/flutter/blob/91b2d41a66d1c540233b819525553afc0fa1f58d/DEPS#L573)) to contain the tag from the command above (version:7.5.1). 4. Run `gclient sync` to verify that the dependency can be fetched.