Remove unnecessary Material import from cupertino/slider_test.dart#180957
Merged
auto-submit[bot] merged 1 commit intoFeb 3, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly removes the unnecessary Material import and Material widget wrappers from cupertino/slider_test.dart. The changes are clean and improve the tests by removing a dependency that is not required for CupertinoSlider. I've added one comment regarding code formatting that should be applied throughout the file for consistency.
victorsanni
approved these changes
Jan 14, 2026
a185d8b to
f1afb99
Compare
Contributor
|
From the failed analyzer: |
Contributor
Author
|
Thanks for pointing that out! I've pushed a fix to remove |
justinmc
approved these changes
Jan 17, 2026
justinmc
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍. I guess these tests were copied from the Material Slider tests, hence the use of the Material widget. Thanks for helping us decouple!
I see there is a CLA failure, have you signed the CLA? https://github.com/flutter/flutter/pull/180957/checks?check_run_id=60534564561
55 tasks
Contributor
Author
|
@googlebot I signed it! |
Contributor
|
@nathannewyen looks like the CLA check is failing because Claude is credited as a coauthor of a commit, and that Claude associated email is being flagged as having not signed the CLA. Could you remove that commit and make the change again without Claude getting attached to the commit? |
The CupertinoSlider tests were using Material widget wrappers unnecessarily. CupertinoSlider is a Cupertino widget that doesn't require Material ancestors. Also removes slider_test.dart from knownCupertinoCrossImports since it no longer has cross imports. Contributes to flutter#177412
50f2360 to
87622bd
Compare
Contributor
Author
|
Fixed! Removed the co-author and squashed the commits. |
Contributor
|
@nathannewyen I suppose I should rebase #181634 after this lands? We both did fix this test it seems. |
Contributor
|
Rebased on top of this one, so no worries |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 4, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 4, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 5, 2026
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Feb 5, 2026
Roll Flutter from bf701fefec86 to f916dd6887bf (44 revisions) flutter/flutter@bf701fe...f916dd6 2026-02-05 nemeth@marcell.it Implement macOS wide gamut (Display P3) support (flutter/flutter#181769) 2026-02-04 engine-flutter-autoroll@skia.org Roll Skia from d23ecfbfdff9 to 8543ce512d5c (3 revisions) (flutter/flutter#181923) 2026-02-04 engine-flutter-autoroll@skia.org Roll Dart SDK from 8001c99d952b to 8f778ffd318b (3 revisions) (flutter/flutter#181927) 2026-02-04 jason-simmons@users.noreply.github.com Re-enable AddressSanitizer on the linux_unopt builder (flutter/flutter#181741) 2026-02-04 1063596+reidbaker@users.noreply.github.com Add exception to log message in ContentSizingFlag.java (flutter/flutter#181813) 2026-02-04 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#181925) 2026-02-04 nshahan@google.com [flutter_tools] Deprecate web hot reload flag (flutter/flutter#181884) 2026-02-04 magder@google.com Marks platform_views_scroll_perf_impeller__timeline_summary unflaky (flutter/flutter#181649) 2026-02-04 engine-flutter-autoroll@skia.org Roll Dart SDK from 204db085d970 to 8001c99d952b (1 revision) (flutter/flutter#181902) 2026-02-04 engine-flutter-autoroll@skia.org Roll Skia from f37a22506eb4 to d23ecfbfdff9 (23 revisions) (flutter/flutter#181915) 2026-02-04 jason-simmons@users.noreply.github.com In the Web codec tests, skip an undecodable image that is used to test a Skia error handling code path. (flutter/flutter#181870) 2026-02-04 engine-flutter-autoroll@skia.org Roll Packages from 5b1bea8 to 3bddf2c (5 revisions) (flutter/flutter#181918) 2026-02-04 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from UmQaaNuhkiuE8Dzug... to J2QdLcY2gyt4NP_xV... (flutter/flutter#181893) 2026-02-04 engine-flutter-autoroll@skia.org Roll Dart SDK from 54322a0b1109 to 204db085d970 (3 revisions) (flutter/flutter#181890) 2026-02-04 nurdaulet.97@gmail.com Cleanup cross imports (flutter/flutter#181807) 2026-02-04 kazbek.sultanov.doc@gmail.com [Material] Remove Material import from backdrop_filter_test.dart widget tests (flutter/flutter#181386) 2026-02-04 kazbek.sultanov.doc@gmail.com Move CheckedModeBanner tests to material and remove Material import from widgets banner_test (flutter/flutter#181261) 2026-02-04 git@reb0.org feat: Pass parameters from DropdownMenuFormField to DropDownMenu (flutter/flutter#181373) 2026-02-04 116356835+AbdeMohlbi@users.noreply.github.com Remove `Config complete` log when using `flutter build apk --config-only` (flutter/flutter#181864) 2026-02-04 flar@google.com [Impeller] Fix flattening of very large zoomed curves with tiny stroke widths (flutter/flutter#181505) 2026-02-03 prbillingsley89@gmail.com Propagates Overlay's MediaQueryData to OverlayPortal child (flutter/flutter#181579) 2026-02-03 ahmedsameha1@gmail.com Make sure that an AnimatedScale doesn't crash in 0x0 environment (flutter/flutter#181481) 2026-02-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 56294a92d5cc to 54322a0b1109 (1 revision) (flutter/flutter#181872) 2026-02-03 zemanux@users.noreply.github.com Fix decorated box (flutter/flutter#179802) 2026-02-03 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#181871) 2026-02-03 70534390+Erengun@users.noreply.github.com Remove Material library dependency from expansible_test.dart (flutter/flutter#181657) 2026-02-03 evanwall@buffalo.edu Organize and update fragment shader uniform tests. (flutter/flutter#181822) 2026-02-03 1961493+harryterkelsen@users.noreply.github.com fix(web_ui): handle non-invertible matrices in ImageFilter.matrix (flutter/flutter#181742) 2026-02-03 nhan13574@gmail.com Remove unnecessary Material import from cupertino/slider_test.dart (flutter/flutter#180957) 2026-02-03 15619084+vashworth@users.noreply.github.com Remove the Flutter.xcframework as a swift dependency (flutter/flutter#181739) 2026-02-03 matt.kosarek@canonical.com feature: implementation of tooltips in the `_TestWindowingOwner` and minor bugfixes to the multiple windows example app (flutter/flutter#181510) 2026-02-03 737941+loic-sharma@users.noreply.github.com [Web] Fix flt-platform-view comment (flutter/flutter#181576) 2026-02-03 fluttergithubbot@gmail.com Marks Linux_pixel_7pro android_verified_input_test to be unflaky (flutter/flutter#179120) 2026-02-03 34871572+gmackall@users.noreply.github.com Unmark `hybrid_android_views_integration_test` as bringup (flutter/flutter#181628) 2026-02-03 brackenavaron@gmail.com Remove material from sliver_tree_test.dart (flutter/flutter#181415) 2026-02-03 34871572+gmackall@users.noreply.github.com Make `android_plugin_new_output_dir_test` only build release (flutter/flutter#181677) 2026-02-03 737941+loic-sharma@users.noreply.github.com Roll customer tests (flutter/flutter#181825) 2026-02-03 41432658+jonathimer@users.noreply.github.com Add Linux Foundation Health Score badge to README (flutter/flutter#175587) 2026-02-03 116356835+AbdeMohlbi@users.noreply.github.com Remove unused getters on AndroidProject class (flutter/flutter#181860) 2026-02-03 47866232+chunhtai@users.noreply.github.com Adds batch release doc for flutter/package (flutter/flutter#181676) 2026-02-03 bkonyi@google.com [ Tool ] Don't use `globals.platform` in `getFlutterRoot()` (flutter/flutter#181859) 2026-02-03 engine-flutter-autoroll@skia.org Roll Packages from 837dbbd to 5b1bea8 (10 revisions) (flutter/flutter#181857) 2026-02-03 brackenavaron@gmail.com Remove material from basic_test.dart (flutter/flutter#181444) 2026-02-03 bkonyi@google.com [ Tool ] Fix regression introduced in flutter/flutter#181421 (flutter/flutter#181826) If this roll has caused a breakage, revert this CL and stop the roller ...
LongCatIsLooong
pushed a commit
to LongCatIsLooong/flutter
that referenced
this pull request
Feb 6, 2026
…lutter#180957) ## Description Remove unnecessary Material import and Material widget wrappers from `cupertino/slider_test.dart`. The CupertinoSlider tests were using `Material` widget wrappers unnecessarily. CupertinoSlider is a Cupertino widget that doesn't require Material ancestors. ## Related Issue Contributes to flutter#177412 ## Tests All 21 tests in `slider_test.dart` pass after this change.
flutter-zl
pushed a commit
to flutter-zl/flutter
that referenced
this pull request
Feb 10, 2026
…lutter#180957) ## Description Remove unnecessary Material import and Material widget wrappers from `cupertino/slider_test.dart`. The CupertinoSlider tests were using `Material` widget wrappers unnecessarily. CupertinoSlider is a Cupertino widget that doesn't require Material ancestors. ## Related Issue Contributes to flutter#177412 ## Tests All 21 tests in `slider_test.dart` pass after this change.
rickhohler
pushed a commit
to rickhohler/flutter
that referenced
this pull request
Feb 19, 2026
…lutter#180957) ## Description Remove unnecessary Material import and Material widget wrappers from `cupertino/slider_test.dart`. The CupertinoSlider tests were using `Material` widget wrappers unnecessarily. CupertinoSlider is a Cupertino widget that doesn't require Material ancestors. ## Related Issue Contributes to flutter#177412 ## Tests All 21 tests in `slider_test.dart` pass after this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove unnecessary Material import and Material widget wrappers from
cupertino/slider_test.dart.The CupertinoSlider tests were using
Materialwidget wrappers unnecessarily. CupertinoSlider is a Cupertino widget that doesn't require Material ancestors.Related Issue
Contributes to #177412
Tests
All 21 tests in
slider_test.dartpass after this change.