-
Notifications
You must be signed in to change notification settings - Fork 30.3k
Design doc - Flutter style updates #180607
Copy link
Copy link
Closed
Labels
📜Issue was posted to Discord. Remove to have the issue reannounced. (For "design doc", "emergency")Issue was posted to Discord. Remove to have the issue reannounced. (For "design doc", "emergency")P2Important issues not at the top of the work listImportant issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.design docTracks a design discussion documentTracks a design discussion documentengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.r: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versionteam-frameworkOwned by Framework teamOwned by Framework teamtriaged-frameworkTriaged by Framework teamTriaged by Framework team
Description
Metadata
Metadata
Assignees
Labels
📜Issue was posted to Discord. Remove to have the issue reannounced. (For "design doc", "emergency")Issue was posted to Discord. Remove to have the issue reannounced. (For "design doc", "emergency")P2Important issues not at the top of the work listImportant issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.design docTracks a design discussion documentTracks a design discussion documentengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.r: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versionteam-frameworkOwned by Framework teamOwned by Framework teamtriaged-frameworkTriaged by Framework teamTriaged by Framework team
Document Link
https://flutter.dev/go/flutter-style-updates
What problem are you solving?
Over the last year, new language features from Dart (dot shorthands) and new lints (e.g. omit_obvious_local_variable_types) have become available, the later which we planned to adopt as part of merging flutter/flutter and flutter/engine with a unified style. Now that these are available, we need to decide on how and to what degree the Flutter framework (flutter/flutter/packages/flutter) will adopt these features.
In addition to these new features in Dart, this year flutter/flutter has also begun using Gemini Code Assist to help with code review in the repository. It refers to the style guide when reviewing pull requests, and has revealed a few points that are slightly ambiguous, or no longer relevant based on having adopted dart format at the end of 2024. This can contribute to the bot making poor recommendations to contributors on pull requests, and so should be clarified in the style guide.