Skip to content

Commit fafe9c3

Browse files
Replace more references to flutter/engine with flutter/flutter (#182654)
towards #167478 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 parent 8d3b8d8 commit fafe9c3

4 files changed

Lines changed: 4 additions & 4 deletions

File tree

dev/devicelab/bin/tasks/hello_world_impeller.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ Future<TaskResult> run() async {
4343
isUsingValidationLayers = true;
4444
}
4545
// "ImpellerValidationBreak" comes from the engine:
46-
// https://github.com/flutter/engine/blob/4160ebacdae2081d6f3160432f5f0dd87dbebec1/impeller/base/validation.cc#L40
46+
// https://github.com/flutter/flutter/blob/91b2d41a66d1c540233b819525553afc0fa1f58d/engine/src/flutter/impeller/base/validation.cc#L54
4747
if (data.contains('ImpellerValidationBreak')) {
4848
hasValidationErrors = true;
4949
}

docs/engine/impeller/Flutter-GPU.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ dependencies:
3232
3333
- [Project dashboard](https://github.com/orgs/flutter/projects/134/views/1)
3434
- [Original design doc](https://flutter.dev/go/impeller-dart) (now outdated!)
35-
- [flutter_gpu package source](https://github.com/flutter/engine/tree/main/lib/gpu)
35+
- [flutter_gpu package source](https://github.com/flutter/flutter/tree/main/engine/src/flutter/lib/gpu)
3636
3737
## Dart FFI
3838

docs/platforms/android/Texture-Layer-Hybrid-Composition.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ It was introduced in Flutter 3.0 to combine the best aspects of Virtual Display
88

99
# Approach
1010

11-
TLHC uses a [custom `FrameLayout`](https://github.com/flutter/engine/blob/7025645c52bfaeb1cc67be5ca842b65772c89c8e/shell/platform/android/io/flutter/plugin/platform/PlatformViewWrapper.java#L35-L46), which is placed in the native view hierarchy as normal, but [redirects drawing](https://github.com/flutter/engine/blob/7025645c52bfaeb1cc67be5ca842b65772c89c8e/shell/platform/android/io/flutter/plugin/platform/PlatformViewWrapper.java#L299-L309) to a canvas that backs a Flutter [`Texture`](https://api.flutter.dev/flutter/widgets/Texture-class.html) in order to compose with the rest of the Flutter UI as normal (without the layering and threading complexities of Hybrid Composition).
11+
TLHC uses a [custom `FrameLayout`](https://github.com/flutter/flutter/blob/91b2d41a66d1c540233b819525553afc0fa1f58d/engine/src/flutter/shell/platform/android/io/flutter/plugin/platform/PlatformViewWrapper.java#L29-L39), which is placed in the native view hierarchy as normal, but [redirects drawing](https://github.com/flutter/flutter/blob/91b2d41a66d1c540233b819525553afc0fa1f58d/engine/src/flutter/shell/platform/android/io/flutter/plugin/platform/PlatformViewWrapper.java#L178-L187) to a canvas that backs a Flutter [`Texture`](https://api.flutter.dev/flutter/widgets/Texture-class.html) in order to compose with the rest of the Flutter UI as normal (without the layering and threading complexities of Hybrid Composition).
1212

1313
# Limitations
1414

engine/src/flutter/tools/gradle/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ Gradle version that you downloaded and verified.
3030
1. Authenticate with CIPD by running `cipd auth-login`.
3131
2. Run `cipd create -in gradle-7.5.1 -install-mode copy -tag version:7.5.1 -name flutter/gradle` to
3232
upload the new Gradle version to CIPD.
33-
3. Update the `engine/src/flutter/DEPS` Gradle entry (which should look something like [this](https://github.com/flutter/engine/blob/4caaab9f2502481b606b930abeea4a361022fa16/DEPS#L732-L743))
33+
3. Update the `DEPS` Gradle entry (which should look something like [this](https://github.com/flutter/flutter/blob/91b2d41a66d1c540233b819525553afc0fa1f58d/DEPS#L573))
3434
to contain the tag from the command above (version:7.5.1).
3535
4. Run `gclient sync` to verify that the dependency can be fetched.
3636

0 commit comments

Comments
 (0)