Add desktop review teams (#182972)

loic-sharma · web-flow · commit 4849b709370d · 2026-02-28T01:03:12.000Z
Updates CODEOWNERS and labeler to use the new desktop review teams. This ensures folks are automatically notified of desktop PRs. Prior art: #166034 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
diff --git a/.github/labeler.yml b/.github/labeler.yml
@@ -171,12 +171,14 @@ platform-linux:
   - changed-files:
     - any-glob-to-any-file:
       - engine/src/flutter/shell/platform/linux/**/*
+      - packages/flutter_tools/lib/src/linux/**/*
 
 platform-macos:
   - changed-files:
     - any-glob-to-any-file:
       - engine/src/flutter/src/flutter/shell/platform/darwin/common/**/*
       - engine/src/flutter/shell/platform/darwin/macos/**/*
+      - packages/flutter_tools/lib/src/macos/**/*
 
 platform-web:
   - changed-files:
@@ -189,6 +191,7 @@ platform-windows:
   - changed-files:
     - any-glob-to-any-file:
       - engine/src/flutter/shell/platform/windows/**/*
+      - packages/flutter_tools/lib/src/windows/**/*
 
 'customer: gallery':
   - changed-files:
@@ -243,6 +246,31 @@ team-ios:
       - packages/flutter_tools/**/*ios*
       - packages/flutter_tools/**/*macos*
 
+# Keep this synced with CODEOWNERS.
+team-linux:
+  - changed-files:
+    - any-glob-to-any-file:
+      - engine/src/flutter/shell/platform/linux/**/*
+      - packages/flutter_tools/**/linux/*
+      - packages/flutter_tools/**/*linux*
+
+# Keep this synced with CODEOWNERS.
+team-macos:
+  - changed-files:
+    - any-glob-to-any-file:
+      - engine/src/flutter/shell/platform/darwin/common/**/*
+      - engine/src/flutter/shell/platform/darwin/macos/**/*
+      - packages/flutter_tools/**/macos/*
+      - packages/flutter_tools/**/*macos*
+
+# Keep this synced with CODEOWNERS.
+team-windows:
+  - changed-files:
+    - any-glob-to-any-file:
+      - engine/src/flutter/shell/platform/windows/**/*
+      - packages/flutter_tools/**/windows/*
+      - packages/flutter_tools/**/*windows*
+
 team-tool:
   - changed-files:
     - any-glob-to-any-file:
diff --git a/CODEOWNERS b/CODEOWNERS
@@ -35,3 +35,19 @@
 /packages/flutter_tools/**/*xcode* @flutter/ios-reviewers
 /packages/flutter_tools/**/*ios* @flutter/ios-reviewers
 /packages/flutter_tools/**/*macos* @flutter/ios-reviewers
+
+# Linux team - keep this synced with .github/labeler.yml's team-linux section.
+/engine/src/flutter/shell/platform/linux/**/* @flutter/linux-reviewers
+/packages/flutter_tools/**/linux/* @flutter/linux-reviewers
+/packages/flutter_tools/**/*linux* @flutter/linux-reviewers
+
+# macOS team - keep this synced with .github/labeler.yml's team-macos section.
+/engine/src/flutter/src/flutter/shell/platform/darwin/common/**/* @flutter/macos-reviewers
+/engine/src/flutter/shell/platform/darwin/macos/**/* @flutter/macos-reviewers
+/packages/flutter_tools/**/macos/* @flutter/macos-reviewers
+/packages/flutter_tools/**/*macos* @flutter/macos-reviewers
+
+# Windows team - keep this synced with .github/labeler.yml's team-windows section.
+/engine/src/flutter/shell/platform/windows/**/* @flutter/windows-reviewers
+/packages/flutter_tools/**/windows/* @flutter/windows-reviewers
+/packages/flutter_tools/**/*windows* @flutter/windows-reviewers
diff --git a/docs/contributing/Contributor-access.md b/docs/contributing/Contributor-access.md
@@ -125,7 +125,10 @@ We currently have the following review teams:
 * [`android-reviewers`](https://github.com/orgs/flutter/teams/android-reviewers): for folks working on the Android port of Flutter; use `#hackers-android` for discussions.
 * [`devtools-reviewers`](https://github.com/orgs/flutter/teams/devtools-reviewers): for the [devtools](https://github.com/flutter/devtools) repo; use `#hackers-devexp` for discussions.
 * [`ios-reviewers`](https://github.com/orgs/flutter/teams/ios-reviewers): for folks working on the iOS port of Flutter; use `#hackers-ios` for discussions.
+* [`linux-reviewers`](https://github.com/orgs/flutter/teams/linux-reviewers): for folks working on the Linux port of Flutter; use `#hackers-desktop` for discussions.
+* [`macos-reviewers`](https://github.com/orgs/flutter/teams/macos-reviewers): for folks working on the macOS port of Flutter; use `#hackers-desktop` for discussions.
 * [`website-reviewers`](https://github.com/orgs/flutter/teams/website-reviewers): for folks working on www.flutter.dev and docs.flutter.dev; use `#hackers-devrel` for discussions.
+* [`windows-reviewers`](https://github.com/orgs/flutter/teams/windows-reviewers): for folks working on the Windows port of Flutter; use `#hackers-desktop` for discussions.
 
 To create a new team, contact @github-admin on Discord. You will also need to create a `CODEOWNERS` file to actually trigger the review assignment.
 
