Skip to content

Commit 00b5a48

Browse files
Standardize review timeline guidance (#183465)
Currently on the same page we say to ping people: - After two weeks (in When) (and the tl;dr). - After one week (in Who). - Immediately, in step 7 of the PR process overview. This makes it hard for new contributors to understand what the actual expectation is, and in practice the step 7 version creates behavior we don't want (immediately pinging people, usually the wrong ones, instead of waiting for the normal triage process). This standardizes everything on two weeks. --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 parent 6a72c1a commit 00b5a48

1 file changed

Lines changed: 4 additions & 8 deletions

File tree

docs/contributing/Tree-hygiene.md

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -69,10 +69,9 @@ The general process for submitting code to a Flutter repository is as follows:
6969
This doesn’t prohibit the use of coding assistance tools, but what’s submitted does
7070
need to be a contributor’s original creation.
7171

72-
7. Get your code reviewed (see below). You should probably reach out to the relevant
73-
expert(s) for the areas you touched and ask them to review your PR directly.
74-
GitHub sometimes recommends specific reviewers; if you're not sure who to ask,
75-
that's probably a good place to start.
72+
7. Get your code reviewed (see below). If you are a team member, request review
73+
from the relevant expert(s) for the areas you touched. Otherwise, wait for
74+
[reviewers to be assigned](#who).
7675

7776
8. Make sure your PR passes all the pre-commit tests. Consider running some of the
7877
post-commit tests locally (see the
@@ -245,12 +244,9 @@ Code should be reviewed by the owner (tech lead) of the area(s) of the codebase
245244
or someone to whom they have delegated that authority.
246245
If anyone else leaves comments, please also wait for their approval (LGTM) before landing code.
247246

248-
If nobody has reviewed your code after a week, then reach out on our [Chat](Chat.md) channels.
247+
If nobody has reviewed your code after two weeks, then reach out on our [Chat](Chat.md) channels.
249248
The `#hackers-new` channel is a good place to ask for help if you're a new contributor.
250249

251-
_For PRs affecting the `material` and `cupertino` libraries, team members are expected to seek reviewers directly;
252-
they will not be assigned during PR triage._
253-
254250
### How
255251

256252
Code review status is managed via GitHub's approval system. PRs should

0 commit comments

Comments
 (0)