status colors + handling for skipped/errored test results

Grace Petryk · s1n7ax · commit 8befd5c2f1a3 · 2025-12-04T03:52:47.000+05:30
diff --git a/lua/java-test/reports/junit.lua b/lua/java-test/reports/junit.lua
@@ -2,7 +2,7 @@ local class = require('java-core.utils.class')
 local log = require('java-core.utils.log2')
 
 ---@class java-test.JUnitTestReport
----@field private conn uv_tcp_t
+---@field private conn uv.uv_tcp_t
 ---@field private result_parser java-test.TestParser
 ---@field private result_parser_fac java-test.TestParserFactory
 ---@field private report_viewer java-test.ReportViewer
@@ -29,7 +29,7 @@ function JUnitReport:show_report()
 end
 
 ---Returns a stream reader function
----@param conn uv_tcp_t
+---@param conn uv.uv_tcp_t
 ---@return fun(err: string, buffer: string) # callback function
 function JUnitReport:get_stream_reader(conn)
 	self.conn = conn
diff --git a/lua/java-test/results/message-id.lua b/lua/java-test/results/message-id.lua
@@ -23,8 +23,6 @@ local MessageId = {
 	ActualEnd = '%ACTUALE',
 	TraceStart = '%TRACES',
 	TraceEnd = '%TRACEE',
-	IGNORE_TEST_PREFIX = '@Ignore: ',
-	ASSUMPTION_FAILED_TEST_PREFIX = '@AssumptionFailure: ',
 }
 
 return MessageId
diff --git a/lua/java-test/results/result-parser.lua b/lua/java-test/results/result-parser.lua
@@ -19,6 +19,13 @@ TestParser.node_parsers = {
 	[MessageId.TestStart] = 'parse_test_start',
 	[MessageId.TestEnd] = 'parse_test_end',
 	[MessageId.TestFailed] = 'parse_test_failed',
+	[MessageId.TestError] = 'parse_test_failed',
+}
+
+---@private
+TestParser.skip_prefixes = {
+	'@Ignore:',
+	'@AssumptionFailure:',
 }
 
 ---@private
@@ -101,6 +108,12 @@ function TestParser:parse_test_end(data)
 	local node = self:find_result_node(test_id)
 	assert(node)
 	node.result.execution = TestExecStatus.Ended
+
+	for _, prefix in ipairs(TestParser.skip_prefixes) do
+		if string.match(data[2], '^'..prefix) then
+			node.result.status = TestStatus.Skipped
+		end
+	end
 end
 
 ---@private
@@ -109,7 +122,13 @@ function TestParser:parse_test_failed(data, line_iter)
 	local node = self:find_result_node(test_id)
 	assert(node)
 
-	node.result.status = TestStatus.Failed
+	node.result.status = node.result.status or TestStatus.Failed
+
+	for _, prefix in ipairs(TestParser.skip_prefixes) do
+		if string.match(data[2], '^'..prefix) then
+			node.result.status = TestStatus.Skipped
+		end
+	end
 
 	while true do
 		local line = line_iter()
diff --git a/lua/java-test/results/result-status.lua b/lua/java-test/results/result-status.lua
@@ -1,7 +1,12 @@
----@enum java-test.TestStatus
+---@class java-test.TestStatus 
+---@field icon string
+---@field highlight string
+
+---@type { [string]: java-test.TestStatus}
 local TestStatus = {
-	Failed = 'failed',
-	Skipped = 'skipped',
+	Failed = { icon = ' ', highlight = 'DiagnosticError'},
+	Skipped = { icon = ' ', highlight = 'DiagnosticWarn'},
+	Passed = { icon = ' ', highlight = 'DiagnosticOk'},
 }
 
 return TestStatus
diff --git a/lua/java-test/ui/floating-report-viewer.lua b/lua/java-test/ui/floating-report-viewer.lua
@@ -24,12 +24,10 @@ function FloatingReportViewer:show(test_results)
 			if result.is_suite then
 				tc.append(' ' .. result.test_name).lbreak()
 			else
+				local status = result.result.status or TestStatus.Passed
+				tc.append(status.icon .. result.test_name).lbreak()
 				if result.result.status == TestStatus.Failed then
-					tc.append('󰅙 ' .. result.test_name).lbreak().append(indentation).append(result.result.trace, indentation)
-				elseif result.result.status == TestStatus.Skipped then
-					tc.append(' ' .. result.test_name).lbreak()
-				else
-					tc.append(' ' .. result.test_name).lbreak()
+					tc.append(indentation).append(result.result.trace, indentation)
 				end
 			end
 
@@ -45,10 +43,19 @@ function FloatingReportViewer:show(test_results)
 
 	local res = build_result(test_results, '', '')
 
-	self:show_in_window(vim.split(res, '\n'))
+	FloatingReportViewer.show_in_window(vim.split(res, '\n'))
 end
 
-function FloatingReportViewer:show_in_window(content)
+function FloatingReportViewer.show_in_window(content)
+	vim.api.nvim_create_autocmd('BufWinEnter', {
+		once = true,
+		callback = function()
+			for _, status in pairs(TestStatus) do
+				vim.fn.matchadd(status.highlight, status.icon)
+			end
+		end,
+	})
+
 	local Popup = require('nui.popup')
 	local event = require('nui.utils.autocmd').event
 

Original file line number	Diff line number	Diff line change
`@@ -23,8 +23,6 @@ local MessageId = {`
`23`	`23`	`ActualEnd = '%ACTUALE',`
`24`	`24`	`TraceStart = '%TRACES',`
`25`	`25`	`TraceEnd = '%TRACEE',`
`26`		`- IGNORE_TEST_PREFIX = '@Ignore: ',`
`27`		`- ASSUMPTION_FAILED_TEST_PREFIX = '@AssumptionFailure: ',`
`28`	`26`	`}`
`29`	`27`
`30`	`28`	`return MessageId`