Skip to content

Commit a4ffa0c

Browse files
srl295srl295
committed
tools: fix ICU shrinker and docs
- tools: path to ICU datafile moved - docs: configure is now configure.py Fixes: nodejs#23245 PR-URL: nodejs#23266 Reviewed-By: Refael Ackermann <refack@gmail.com>
1 parent 3d21245 commit a4ffa0c

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

‎tools/icu/README.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ make clean
9292
tools/license-builder.sh
9393
```
9494

95-
- Now, fix the default URL for the `full-icu` build in `/configure`, in
95+
- Now, fix the default URL for the `full-icu` build in `/configure.py`, in
9696
the `configure_intl()` function. It should match the ICU URL used in the
9797
first step. When this is done, the following should build with full ICU.
9898

@@ -104,7 +104,7 @@ make
104104
make test-ci
105105
```
106106

107-
- commit the change to `configure` along with the updated `LICENSE` file.
107+
- commit the change to `configure.py` along with the updated `LICENSE` file.
108108

109109
- Note: To simplify review, I often will “pre-land” this patch, meaning that
110110
I run the patch through `curl -L https://github.com/nodejs/node/pull/xxx.patch

‎tools/icu/shrink-icu-src.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
parser.add_option('--icutmp',
2323
action='store',
2424
dest='icutmp',
25-
default='out/Release/gen/icutmp',
25+
default='out/Release/obj/gen/icutmp',
2626
help='path to icutmp dir.')
2727

2828

0 commit comments

Comments
 (0)