Skip to content

Commit 7c64133

Browse files
committed
src: fix Set() usage in env-inl.h
PR-URL: nodejs#24060 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
1 parent ff0719d commit 7c64133

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

src/env-inl.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -736,7 +736,7 @@ inline void Environment::SetMethod(v8::Local<v8::Object> that,
736736
const v8::NewStringType type = v8::NewStringType::kInternalized;
737737
v8::Local<v8::String> name_string =
738738
v8::String::NewFromUtf8(isolate(), name, type).ToLocalChecked();
739-
that->Set(name_string, function);
739+
that->Set(context, name_string, function).FromJust();
740740
function->SetName(name_string); // NODE_SET_METHOD() compatibility.
741741
}
742742

@@ -756,7 +756,7 @@ inline void Environment::SetMethodNoSideEffect(v8::Local<v8::Object> that,
756756
const v8::NewStringType type = v8::NewStringType::kInternalized;
757757
v8::Local<v8::String> name_string =
758758
v8::String::NewFromUtf8(isolate(), name, type).ToLocalChecked();
759-
that->Set(name_string, function);
759+
that->Set(context, name_string, function).FromJust();
760760
function->SetName(name_string); // NODE_SET_METHOD() compatibility.
761761
}
762762

0 commit comments

Comments
 (0)