src: mark empty destructors as default

bnoordhuis · bnoordhuis · commit 5ab87dba738d · 2014-10-23T22:49:59.000+02:00
Mark empty destructors as having a default no-op implementation.
Remove a few unused constructors and destructors while we are here.
diff --git a/src/async-wrap-inl.h b/src/async-wrap-inl.h
@@ -54,9 +54,6 @@ inline AsyncWrap::AsyncWrap(Environment* env,
 }
 
 
-inline AsyncWrap::~AsyncWrap() {
-}
-
 inline uint32_t AsyncWrap::provider_type() const {
   return provider_type_;
 }
diff --git a/src/async-wrap.h b/src/async-wrap.h
@@ -61,7 +61,7 @@ class AsyncWrap : public BaseObject {
                    v8::Handle<v8::Object> object,
                    ProviderType provider);
 
-  inline ~AsyncWrap();
+  inline ~AsyncWrap() = default;
 
   inline bool has_async_listener();
 
diff --git a/src/node.cc b/src/node.cc
@@ -159,12 +159,12 @@ class ArrayBufferAllocator : public ArrayBuffer::Allocator {
   // the process.
   static const size_t kMaxLength = 0x3fffffff;
   static ArrayBufferAllocator the_singleton;
-  virtual ~ArrayBufferAllocator() {}
+  virtual ~ArrayBufferAllocator() = default;
   virtual void* Allocate(size_t length) override;
   virtual void* AllocateUninitialized(size_t length) override;
   virtual void Free(void* data, size_t length) override;
  private:
-  ArrayBufferAllocator() {}
+  ArrayBufferAllocator() = default;
   DISALLOW_COPY_AND_ASSIGN(ArrayBufferAllocator);
 };
 
diff --git a/src/node_crypto_clienthello.h b/src/node_crypto_clienthello.h
@@ -47,9 +47,6 @@ class ClientHelloParser {
 
   class ClientHello {
    public:
-    ClientHello() {
-    }
-
     inline uint8_t session_size() const { return session_size_; }
     inline const uint8_t* session_id() const { return session_id_; }
     inline bool has_ticket() const { return has_ticket_; }
diff --git a/src/node_v8_platform.cc b/src/node_v8_platform.cc
@@ -35,9 +35,6 @@ using v8::Isolate;
 // The last task to encounter before killing the worker
 class StopTask : public Task {
  public:
-  StopTask() {}
-  ~StopTask() {}
-
   void Run() {}
 };
 
diff --git a/src/process_wrap.cc b/src/process_wrap.cc
@@ -84,9 +84,6 @@ class ProcessWrap : public HandleWrap {
                    AsyncWrap::PROVIDER_PROCESSWRAP) {
   }
 
-  ~ProcessWrap() {
-  }
-
   static void ParseStdioOptions(Environment* env,
                                 Local<Object> js_options,
                                 uv_process_options_t* options) {
diff --git a/src/signal_wrap.cc b/src/signal_wrap.cc
@@ -80,9 +80,6 @@ class SignalWrap : public HandleWrap {
     CHECK_EQ(r, 0);
   }
 
-  ~SignalWrap() {
-  }
-
   static void Start(const FunctionCallbackInfo<Value>& args) {
     SignalWrap* wrap = Unwrap<SignalWrap>(args.Holder());
     int signum = args[0]->Int32Value();
diff --git a/src/stream_wrap.h b/src/stream_wrap.h
@@ -72,8 +72,7 @@ class StreamWrapCallbacks {
   explicit StreamWrapCallbacks(StreamWrapCallbacks* old) : wrap_(old->wrap()) {
   }
 
-  virtual ~StreamWrapCallbacks() {
-  }
+  virtual ~StreamWrapCallbacks() = default;
 
   virtual const char* Error();
 
diff --git a/src/timer_wrap.cc b/src/timer_wrap.cc
@@ -91,9 +91,6 @@ class TimerWrap : public HandleWrap {
     CHECK_EQ(r, 0);
   }
 
-  ~TimerWrap() {
-  }
-
   static void Start(const FunctionCallbackInfo<Value>& args) {
     TimerWrap* wrap = Unwrap<TimerWrap>(args.Holder());
 
diff --git a/src/udp_wrap.cc b/src/udp_wrap.cc
@@ -82,10 +82,6 @@ UDPWrap::UDPWrap(Environment* env, Handle<Object> object)
 }
 
 
-UDPWrap::~UDPWrap() {
-}
-
-
 void UDPWrap::Initialize(Handle<Object> target,
                          Handle<Value> unused,
                          Handle<Context> context) {
diff --git a/src/udp_wrap.h b/src/udp_wrap.h
@@ -58,7 +58,6 @@ class UDPWrap: public HandleWrap {
 
  private:
   UDPWrap(Environment* env, v8::Handle<v8::Object> object);
-  virtual ~UDPWrap() override;
 
   static void DoBind(const v8::FunctionCallbackInfo<v8::Value>& args,
                      int family);

Original file line number	Diff line number	Diff line change
`@@ -54,9 +54,6 @@ inline AsyncWrap::AsyncWrap(Environment* env,`
`54`	`54`	`}`
`55`	`55`
`56`	`56`
`57`		`-inline AsyncWrap::~AsyncWrap() {`
`58`		`-}`
`59`		`-`
`60`	`57`	`inline uint32_t AsyncWrap::provider_type() const {`
`61`	`58`	`return provider_type_;`
`62`	`59`	`}`
Original file line number	Diff line number	Diff line change
`@@ -84,9 +84,6 @@ class ProcessWrap : public HandleWrap {`
`84`	`84`	`AsyncWrap::PROVIDER_PROCESSWRAP) {`
`85`	`85`	`}`
`86`	`86`
`87`		`- ~ProcessWrap() {`
`88`		`- }`
`89`		`-`
`90`	`87`	`static void ParseStdioOptions(Environment* env,`
`91`	`88`	`Local<Object> js_options,`
`92`	`89`	`uv_process_options_t* options) {`
Original file line number	Diff line number	Diff line change
`@@ -80,9 +80,6 @@ class SignalWrap : public HandleWrap {`
`80`	`80`	`CHECK_EQ(r, 0);`
`81`	`81`	`}`
`82`	`82`
`83`		`- ~SignalWrap() {`
`84`		`- }`
`85`		`-`
`86`	`83`	`static void Start(const FunctionCallbackInfo<Value>& args) {`
`87`	`84`	`SignalWrap* wrap = Unwrap<SignalWrap>(args.Holder());`
`88`	`85`	`int signum = args[0]->Int32Value();`
Original file line number	Diff line number	Diff line change
`@@ -72,8 +72,7 @@ class StreamWrapCallbacks {`
`72`	`72`	`explicit StreamWrapCallbacks(StreamWrapCallbacks* old) : wrap_(old->wrap()) {`
`73`	`73`	`}`
`74`	`74`
`75`		`- virtual ~StreamWrapCallbacks() {`
`76`		`- }`
	`75`	`+ virtual ~StreamWrapCallbacks() = default;`
`77`	`76`
`78`	`77`	`virtual const char* Error();`
`79`	`78`
Original file line number	Diff line number	Diff line change
`@@ -91,9 +91,6 @@ class TimerWrap : public HandleWrap {`
`91`	`91`	`CHECK_EQ(r, 0);`
`92`	`92`	`}`
`93`	`93`
`94`		`- ~TimerWrap() {`
`95`		`- }`
`96`		`-`
`97`	`94`	`static void Start(const FunctionCallbackInfo<Value>& args) {`
`98`	`95`	`TimerWrap* wrap = Unwrap<TimerWrap>(args.Holder());`
`99`	`96`
Original file line number	Diff line number	Diff line change
`@@ -82,10 +82,6 @@ UDPWrap::UDPWrap(Environment* env, Handle<Object> object)`
`82`	`82`	`}`
`83`	`83`
`84`	`84`
`85`		`-UDPWrap::~UDPWrap() {`
`86`		`-}`
`87`		`-`
`88`		`-`
`89`	`85`	`void UDPWrap::Initialize(Handle<Object> target,`
`90`	`86`	`Handle<Value> unused,`
`91`	`87`	`Handle<Context> context) {`