tools: rename unused variale in more pythonic way

komawar · BridgeAR · commit 5a17ab3ff3ad · 2017-10-19T02:26:03.000-02:00
The 'Main' function in tools/test.py file was using a variable named ``all_outcomes`` to store a value not being used. It is a best practice to name unused variables, often return values of functions/methods (as in this case) as ``_`` [1]. This just helps keep the code a bit cleaner and avoid any silly mistakes. PR-URL: nodejs#16171 Refs: [1] https://stackoverflow.com/a/5477153 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
diff --git a/tools/test.py b/tools/test.py
@@ -1661,7 +1661,7 @@ def Main():
         }
         test_list = root.ListTests([], path, context, arch, mode)
         unclassified_tests += test_list
-        (cases, unused_rules, all_outcomes) = (
+        (cases, unused_rules, _) = (
             config.ClassifyTests(test_list, env))
         if globally_unused_rules is None:
           globally_unused_rules = set(unused_rules)

Original file line number	Diff line number	Diff line change
`@@ -1661,7 +1661,7 @@ def Main():`
`1661`	`1661`	`}`
`1662`	`1662`	`test_list = root.ListTests([], path, context, arch, mode)`
`1663`	`1663`	`unclassified_tests += test_list`
`1664`		`- (cases, unused_rules, all_outcomes) = (`
	`1664`	`+ (cases, unused_rules, _) = (`
`1665`	`1665`	`config.ClassifyTests(test_list, env))`
`1666`	`1666`	`if globally_unused_rules is None:`
`1667`	`1667`	`globally_unused_rules = set(unused_rules)`