From 5d8a1b5ce8a70d602d30e2e57b6f4ffc7cc3307f Mon Sep 17 00:00:00 2001 From: Jason Laster Date: Mon, 12 Jun 2017 10:17:45 -0400 Subject: [PATCH 1/2] Add void types --- src/components/Editor/SearchBar.js | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/components/Editor/SearchBar.js b/src/components/Editor/SearchBar.js index c7570d0c19..72506b11ba 100644 --- a/src/components/Editor/SearchBar.js +++ b/src/components/Editor/SearchBar.js @@ -101,23 +101,23 @@ class SearchBar extends Component { editor?: SourceEditor, symbols: SymbolDeclarations, symbolSearchResults: Array<*>, - selectSource: (string, ?SelectSourceOptions) => any, + selectSource: (string, ?SelectSourceOptions) => void, selectedSource?: SourceRecord, - highlightLineRange: ({ start: number, end: number }) => any, - clearHighlightLineRange: () => any, + highlightLineRange: ({ start: number, end: number }) => void, + clearHighlightLineRange: () => void, searchOn?: boolean, - toggleFileSearch: (?boolean) => any, + toggleFileSearch: (?boolean) => void, searchResults: SearchResults, modifiers: FileSearchModifiers, - toggleFileSearchModifier: string => any, + toggleFileSearchModifier: string => void, symbolSearchOn: boolean, selectedSymbolType: SymbolSearchType, - toggleSymbolSearch: boolean => any, - setSelectedSymbolType: SymbolSearchType => any, + toggleSymbolSearch: boolean => void, + setSelectedSymbolType: SymbolSearchType => void, query: string, - setFileSearchQuery: string => any, - updateSearchResults: ({ count: number, index?: number }) => any, - updateSymbolSearchResults: ({ count: number, index?: number }) => any + setFileSearchQuery: string => void, + updateSearchResults: ({ count: number, index?: number }) => void, + updateSymbolSearchResults: ({ count: number, index?: number }) => void }; constructor(props) { From d5718c5bbb8b4fe598f8a773b05139903c478a5f Mon Sep 17 00:00:00 2001 From: Jason Laster Date: Mon, 12 Jun 2017 10:31:41 -0400 Subject: [PATCH 2/2] add more voids --- src/components/Editor/Footer.js | 10 +++++----- src/components/Editor/Preview.js | 8 ++++---- src/components/Editor/Tabs.js | 16 ++++++++-------- src/components/Outline.js | 2 +- src/components/SecondaryPanes/CommandBar.js | 12 ++++++------ src/components/SecondaryPanes/EventListeners.js | 10 +++++----- src/components/SecondaryPanes/Expressions.js | 10 +++++----- src/components/SecondaryPanes/index.js | 4 ++-- src/components/shared/Accordion.js | 4 ++-- src/components/shared/Autocomplete.js | 6 +++--- src/components/shared/Button/PaneToggle.js | 2 +- src/components/shared/ManagedTree.js | 6 +++--- src/components/shared/ObjectInspector.js | 2 +- src/components/shared/ResultList.js | 2 +- src/components/shared/SearchInput.js | 16 ++++++++-------- 15 files changed, 55 insertions(+), 55 deletions(-) diff --git a/src/components/Editor/Footer.js b/src/components/Editor/Footer.js index 1c61504199..da2acb633f 100644 --- a/src/components/Editor/Footer.js +++ b/src/components/Editor/Footer.js @@ -23,12 +23,12 @@ import "./Footer.css"; class SourceFooter extends PureComponent { props: { selectedSource: SourceRecord, - selectSource: (string, ?Object) => any, + selectSource: (string, ?Object) => void, editor: any, - togglePrettyPrint: string => any, - toggleBlackBox: () => any, - recordCoverage: () => any, - togglePaneCollapse: () => any, + togglePrettyPrint: string => void, + toggleBlackBox: () => void, + recordCoverage: () => void, + togglePaneCollapse: () => void, endPanelCollapsed: boolean, horizontal: boolean }; diff --git a/src/components/Editor/Preview.js b/src/components/Editor/Preview.js index bbebdaf242..931d70bfbb 100644 --- a/src/components/Editor/Preview.js +++ b/src/components/Editor/Preview.js @@ -22,14 +22,14 @@ import "./Preview.css"; class Preview extends Component { props: { - loadObjectProperties: Object => any, - addExpression: (string, ?Object) => any, + loadObjectProperties: Object => void, + addExpression: (string, ?Object) => void, loadedObjects: Object, popoverTarget: Object, value: Object, expression: string, - onClose: () => any, - selectSourceURL: (string, Object) => any + onClose: () => void, + selectSourceURL: (string, Object) => void }; componentDidMount() { diff --git a/src/components/Editor/Tabs.js b/src/components/Editor/Tabs.js index 75e85c4515..96f9271b45 100644 --- a/src/components/Editor/Tabs.js +++ b/src/components/Editor/Tabs.js @@ -96,14 +96,14 @@ class SourceTabs extends PureComponent { props: { sourceTabs: SourcesList, selectedSource: SourceRecord, - selectSource: (string, ?Object) => any, - moveTab: (string, number) => any, - closeTab: string => any, - closeTabs: (List) => any, - toggleProjectSearch: () => any, - togglePrettyPrint: string => any, - togglePaneCollapse: () => any, - showSource: string => any, + selectSource: (string, ?Object) => void, + moveTab: (string, number) => void, + closeTab: string => void, + closeTabs: (List) => void, + toggleProjectSearch: () => void, + togglePrettyPrint: string => void, + togglePaneCollapse: () => void, + showSource: string => void, horizontal: boolean, startPanelCollapsed: boolean, endPanelCollapsed: boolean diff --git a/src/components/Outline.js b/src/components/Outline.js index 6233bf2f72..4bef5d7654 100644 --- a/src/components/Outline.js +++ b/src/components/Outline.js @@ -22,7 +22,7 @@ class Outline extends Component { props: { isHidden: boolean, symbols: SymbolDeclarations, - selectSource: (string, { line: number }) => any, + selectSource: (string, { line: number }) => void, selectedSource: ?SourceRecord }; diff --git a/src/components/SecondaryPanes/CommandBar.js b/src/components/SecondaryPanes/CommandBar.js index 0e2568a03e..acc11a1f80 100644 --- a/src/components/SecondaryPanes/CommandBar.js +++ b/src/components/SecondaryPanes/CommandBar.js @@ -102,13 +102,13 @@ class CommandBar extends Component { props: { sources: SourcesMap, selectedSource: SourceRecord, - resume: () => any, - stepIn: () => any, - stepOut: () => any, - stepOver: () => any, - breakOnNext: () => any, + resume: () => void, + stepIn: () => void, + stepOut: () => void, + stepOver: () => void, + breakOnNext: () => void, pause: any, - pauseOnExceptions: (boolean, boolean) => any, + pauseOnExceptions: (boolean, boolean) => void, shouldPauseOnExceptions: boolean, shouldIgnoreCaughtExceptions: boolean, isWaitingOnBreak: boolean diff --git a/src/components/SecondaryPanes/EventListeners.js b/src/components/SecondaryPanes/EventListeners.js index b5e541d7c6..4f8de22a7d 100644 --- a/src/components/SecondaryPanes/EventListeners.js +++ b/src/components/SecondaryPanes/EventListeners.js @@ -23,11 +23,11 @@ class EventListeners extends Component { props: { listeners: Array, - selectSource: (SourceId, { line: number }) => any, - addBreakpoint: ({ sourceId: SourceId, line: number }) => any, - enableBreakpoint: Location => any, - disableBreakpoint: Location => any, - removeBreakpoint: Location => any + selectSource: (SourceId, { line: number }) => void, + addBreakpoint: ({ sourceId: SourceId, line: number }) => void, + enableBreakpoint: Location => void, + disableBreakpoint: Location => void, + removeBreakpoint: Location => void }; constructor(...args) { diff --git a/src/components/SecondaryPanes/Expressions.js b/src/components/SecondaryPanes/Expressions.js index 39e09fddde..892ef1956c 100644 --- a/src/components/SecondaryPanes/Expressions.js +++ b/src/components/SecondaryPanes/Expressions.js @@ -67,11 +67,11 @@ class Expressions extends PureComponent { props: { expressions: List, - addExpression: (string, ?Object) => any, - evaluateExpressions: () => any, - updateExpression: (string, Expression) => any, - deleteExpression: Expression => any, - loadObjectProperties: () => any, + addExpression: (string, ?Object) => void, + evaluateExpressions: () => void, + updateExpression: (string, Expression) => void, + deleteExpression: Expression => void, + loadObjectProperties: () => void, loadedObjects: Map }; diff --git a/src/components/SecondaryPanes/index.js b/src/components/SecondaryPanes/index.js index 6db5ce8e08..10b0a85627 100644 --- a/src/components/SecondaryPanes/index.js +++ b/src/components/SecondaryPanes/index.js @@ -50,8 +50,8 @@ type SecondaryPanesItems = { header: string, component: any, opened?: boolean, - onToggle?: () => any, - shouldOpen?: () => any, + onToggle?: () => void, + shouldOpen?: () => void, buttons?: any }; diff --git a/src/components/shared/Accordion.js b/src/components/shared/Accordion.js index c24783964a..ebba8c9954 100644 --- a/src/components/shared/Accordion.js +++ b/src/components/shared/Accordion.js @@ -9,8 +9,8 @@ type AccordionItem = { component(): any, header: string, opened: boolean, - onToggle?: () => any, - shouldOpen?: () => any + onToggle?: () => void, + shouldOpen?: () => void }; type Props = { items: Array }; diff --git a/src/components/shared/Autocomplete.js b/src/components/shared/Autocomplete.js index f3d015deb5..31b3d1fa14 100644 --- a/src/components/shared/Autocomplete.js +++ b/src/components/shared/Autocomplete.js @@ -21,10 +21,10 @@ type State = { }; type Props = { - selectItem: (event: SyntheticKeyboardEvent, item: Object) => any, - onSelectedItem: (selectedItem: Object) => any, + selectItem: (event: SyntheticKeyboardEvent, item: Object) => void, + onSelectedItem: (selectedItem: Object) => void, items: Array, - close: (value: any) => any, + close: (value: any) => void, inputValue: string, placeholder: string, size: string diff --git a/src/components/shared/Button/PaneToggle.js b/src/components/shared/Button/PaneToggle.js index d4cec2be75..db6461acd6 100644 --- a/src/components/shared/Button/PaneToggle.js +++ b/src/components/shared/Button/PaneToggle.js @@ -7,7 +7,7 @@ import "./PaneToggle.css"; type Props = { collapsed: boolean, - handleClick: (string, boolean) => any, + handleClick: (string, boolean) => void, horizontal?: boolean, position: string }; diff --git a/src/components/shared/ManagedTree.js b/src/components/shared/ManagedTree.js index f991bd3355..31fcba22be 100644 --- a/src/components/shared/ManagedTree.js +++ b/src/components/shared/ManagedTree.js @@ -21,9 +21,9 @@ type Props = { highlightItems?: Array, itemHeight: number, listItems?: Array, - onFocus?: (item: any) => any, - onExpand?: (item: any) => any, - onCollapse?: (item: any) => any, + onFocus?: (item: any) => void, + onExpand?: (item: any) => void, + onCollapse?: (item: any) => void, renderItem: any }; diff --git a/src/components/shared/ObjectInspector.js b/src/components/shared/ObjectInspector.js index 48eef2a93d..c0ee99b711 100644 --- a/src/components/shared/ObjectInspector.js +++ b/src/components/shared/ObjectInspector.js @@ -120,7 +120,7 @@ class ObjectInspector extends Component { focused: boolean, _: Object, expanded: boolean, - { setExpanded }: () => any + { setExpanded }: () => void ) { let objectValue; let label = item.name; diff --git a/src/components/shared/ResultList.js b/src/components/shared/ResultList.js index 1abe6b99a9..c851f22de0 100644 --- a/src/components/shared/ResultList.js +++ b/src/components/shared/ResultList.js @@ -18,7 +18,7 @@ type Props = { event: SyntheticKeyboardEvent, item: ResultListItem, index: number - ) => any, + ) => void, size: string }; diff --git a/src/components/shared/SearchInput.js b/src/components/shared/SearchInput.js index d54e4257dd..1c6adaa2d2 100644 --- a/src/components/shared/SearchInput.js +++ b/src/components/shared/SearchInput.js @@ -25,15 +25,15 @@ class SearchInput extends Component { count: number, placeholder: string, summaryMsg: string, - onChange: () => any, - handleClose: () => any, - onKeyUp: () => any, - onKeyDown: () => any, - onFocus: () => any, - onBlur: () => any, + onChange: () => void, + handleClose: () => void, + onKeyUp: () => void, + onKeyDown: () => void, + onFocus: () => void, + onBlur: () => void, size: string, - handleNext: () => any, - handlePrev: () => any + handleNext: () => void, + handlePrev: () => void }; static defaultProps: Object;