Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

[Editor] highlighting line on reload #1964

Description

@jasonLaster

We currently highlight the previously selected location when we start the debugger. I find that to be somewhat distracting as it's no longer that helpful.

It would be nice to open the previously selected source, but not flash the line.

As a bit of back story, this happens because we store the previously selected location as a pendinglocation in prefs. We can use this to open the source, without highlighting the line on reload.

Patch

diff --git a/src/components/Editor/index.js b/src/components/Editor/index.js
index d41d57a..c070c04 100644
--- a/src/components/Editor/index.js
+++ b/src/components/Editor/index.js
@@ -457,6 +457,10 @@ const Editor = React.createClass({
     const line = this.pendingJumpLine;
     this.editor.alignLine(line);

+    // this is where we add the `highlight-line`
+    // I think the closest approximation of what we want to do is to not highlight a line if we don't have a
+    // previously selected location. This would basically mean, don't highlight the first location.
+

GIF

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Fields

    Priority

    None yet

    Jira

    None yet

    Severity

    None yet

    Estimate

    None yet

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions