Merge pull request #47 from chong-shao/fix_gradle_file

kroikie · web-flow · commit 254dd24fbc89 · 2023-06-30T14:48:23.000-07:00
diff --git a/config/README.md b/config/README.md
@@ -16,7 +16,7 @@ Getting started
 1. [Add Firebase to your Android Project](https://firebase.google.com/docs/android/setup).
 2. Create a service account as described in [Adding Firebase to your Server](https://firebase.google.com/docs/admin/setup) and download the JSON file.
   - Copy the private key JSON file to this folder and rename it to `service-account.json`.
-3. Change the `PROJECT_ID` variable in `Configure.java` to your project ID.
+3. Change the build.gradle file under config/, to replace '[YOUR_SERVICE_ACCOUNT_JSON_DIR]' to the directory of `service-account.json`.
 
 Run
 ---
diff --git a/config/build.gradle b/config/build.gradle
@@ -8,7 +8,7 @@ repositories {
     mavenCentral()
 }
 
-run.doFirst { environment 'GOOGLE_APPLICATION_CREDENTIALS', '/Users/chongshao/dev/quickstart-java/config/service-account.json' }
+# run.doFirst { environment 'GOOGLE_APPLICATION_CREDENTIALS', '[YOUR_SERVICE_ACCOUNT_JSON_DIR]' }
 
 run {
     if (project.hasProperty("action")) {
diff --git a/messaging/README.md b/messaging/README.md
@@ -17,7 +17,7 @@ Getting started
 
 1. Create a service account as described in [Adding Firebase to your Server](https://firebase.google.com/docs/admin/setup) and download the JSON file.
   - Copy the json file to this folder and rename it to `service-account.json`.
-2. Change the `PROJECT_ID` variable in `com.google.firebase.quickstart.Messaging.java` to your project ID.
+2. Change the build.gradle file under messaging/, to replace '[YOUR_SERVICE_ACCOUNT_JSON_DIR]' to the directory of `service-account.json`.
 
 Run
 ---
diff --git a/messaging/build.gradle b/messaging/build.gradle
@@ -12,7 +12,7 @@ repositories {
     mavenCentral()
 }
 
-run.doFirst { environment 'GOOGLE_APPLICATION_CREDENTIALS', '/Users/chongshao/dev/quickstart-java/messaging/service-account.json' }
+run.doFirst { environment 'GOOGLE_APPLICATION_CREDENTIALS', '[YOUR_SERVICE_ACCOUNT_JSON_DIR]' }
 
 run {
     if (project.hasProperty("message")) {

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ repositories {`
`8`	`8`	`mavenCentral()`
`9`	`9`	`}`
`10`	`10`
`11`		`-run.doFirst { environment 'GOOGLE_APPLICATION_CREDENTIALS', '/Users/chongshao/dev/quickstart-java/config/service-account.json' }`
	`11`	`+# run.doFirst { environment 'GOOGLE_APPLICATION_CREDENTIALS', '[YOUR_SERVICE_ACCOUNT_JSON_DIR]' }`
`12`	`12`
`13`	`13`	`run {`
`14`	`14`	`if (project.hasProperty("action")) {`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ repositories {`
`12`	`12`	`mavenCentral()`
`13`	`13`	`}`
`14`	`14`
`15`		`-run.doFirst { environment 'GOOGLE_APPLICATION_CREDENTIALS', '/Users/chongshao/dev/quickstart-java/messaging/service-account.json' }`
	`15`	`+run.doFirst { environment 'GOOGLE_APPLICATION_CREDENTIALS', '[YOUR_SERVICE_ACCOUNT_JSON_DIR]' }`
`16`	`16`
`17`	`17`	`run {`
`18`	`18`	`if (project.hasProperty("message")) {`