Skip to content

Add in support for late static binding#88

Merged
robertdimarco merged 1 commit intogoogleapis:masterfrom
chappy84:lsb
Jun 28, 2016
Merged

Add in support for late static binding#88
robertdimarco merged 1 commit intogoogleapis:masterfrom
chappy84:lsb

Conversation

@chappy84
Copy link
Copy Markdown

Enables developers to extend the class and override variables / methods if they so require.

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Apr 11, 2016
@chappy84
Copy link
Copy Markdown
Author

I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Apr 25, 2016
@robertdimarco
Copy link
Copy Markdown

@chappy84 Any chance you'd have time to take a peek at these merge conflicts? I'll merge asap after that; this looks good to me!

… and override variables / methods if they so require
@chappy84
Copy link
Copy Markdown
Author

@robertdimarco Should be all sorted now :)

@robertdimarco robertdimarco merged commit d425647 into googleapis:master Jun 28, 2016
@chappy84 chappy84 deleted the lsb branch June 29, 2016 17:36
@chappy84
Copy link
Copy Markdown
Author

@robertdimarco Thanks for merging :)
I was wondering if there were plans to tag a new version so those using composer can start updating?

@robertdimarco
Copy link
Copy Markdown

@chappy84 Shipped! Thanks for all of your help on this release. =) 🚢

@chappy84
Copy link
Copy Markdown
Author

Thanks @robertdimarco, much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants