Fix exceptions classes#81
Merged
robertdimarco merged 2 commits intogoogleapis:masterfrom Jun 16, 2016
Maks3w:fix-exceptions-classes
Merged
Fix exceptions classes#81robertdimarco merged 2 commits intogoogleapis:masterfrom Maks3w:fix-exceptions-classes
robertdimarco merged 2 commits intogoogleapis:masterfrom
Maks3w:fix-exceptions-classes
Conversation
> Exception thrown if an argument is not of the expected type. http://php.net/manual/en/class.invalidargumentexception.php
RuntimeExceptions is the correct exception error source is the decoded data. Note LogicExceptions as defined in PHP documentation implies a modification in the code by the developer. > Exception that represents error in the program logic. This kind of exception should lead directly to a fix in your code. http://php.net/manual/en/class.logicexception.php But the token is a data provided by an external source which is out side of the control of the developer so there is no way of prevent malformed tokens.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Author
|
I won't sign any kind of CLA. This contribution is free of any kind of right I could have. |
|
Great stuff! Happy to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use InvalidArgumentException when $allowed_algs is not array
Use RuntimeExceptions for exceptions related with unencoded data.
RuntimeExceptions is the correct exception error source is the decoded data.
Note LogicExceptions as defined in PHP documentation implies a modification in the code by the developer.
But the token is a data provided by an external source which is out side of the control of the developer so there is no way of prevent malformed tokens.