Skip to content

feat(firestore): add support for FieldPath in update transactions#18121

Merged
Lyokone merged 2 commits intomainfrom
feat/17287
Mar 19, 2026
Merged

feat(firestore): add support for FieldPath in update transactions#18121
Lyokone merged 2 commits intomainfrom
feat/17287

Conversation

@Lyokone
Copy link
Copy Markdown
Contributor

@Lyokone Lyokone commented Mar 19, 2026

Description

Transaction.update and WriteBatch.update only accepted Map<String, dynamic> for the data parameter, preventing the use of FieldPath keys. This updates both methods to accept Map<Object, Object?> (matching DocumentReference.update) across the full stack: Dart API, platform interface, method channel, Pigeon messages, web interop, and native Android/iOS/macOS/Windows implementations.

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented Mar 19, 2026

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@Lyokone Lyokone merged commit aa1f17a into main Mar 19, 2026
33 of 34 checks passed
@Lyokone Lyokone deleted the feat/17287 branch March 19, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SelaseKay SelaseKay SelaseKay approved these changes

+1 more reviewer

@MichaelVerdon MichaelVerdon MichaelVerdon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[cloud_firestore]: transaction.update accepts data as Map<String, dynamic> but should allow Object keys for FieldPath

3 participants

@Lyokone @SelaseKay @MichaelVerdon