fix(core): bump Firebase C++ SDK to 13.5.0 (CMake deprecation fix)#18071
fix(core): bump Firebase C++ SDK to 13.5.0 (CMake deprecation fix)#18071Lyokone merged 3 commits intofirebase:mainfrom
Conversation
…on warning Resolves firebase#12849. The bundled Firebase C++ SDK 13.4.0 sets cmake_minimum_required(VERSION 3.1), which triggers a deprecation warning on CMake 3.25+ and a hard error on CMake 4.x. Firebase C++ SDK 13.5.0 bumps this to VERSION 3.22, fixing the warning and restoring compatibility with modern CMake.
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
This reverts commit 8f93138.
Description
Bumps
FIREBASE_SDK_VERSIONfrom13.4.0to13.5.0in thefirebase_coreWindows CMakeLists.txt.The bundled Firebase C++ SDK 13.4.0 sets
cmake_minimum_required(VERSION 3.1)in itsCMakeLists.txt, which:Firebase C++ SDK 13.5.0 (firebase/firebase-cpp-sdk#1599) bumps the minimum CMake version to
3.22, resolving both the warning and the hard error.Related Issues
Fixes #12849
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Note on tests: This is a one-line build configuration change (SDK version bump in CMakeLists.txt). The SDK version is validated at CMake build time — the Windows CI workflow's E2E build serves as the integration test. There is no Dart-level behavior change. Verified that firebase_cpp_sdk_windows_13.5.0.zip is available on Google's CDN.
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?