Skip to content

fix(fdc): Fix serializing errors#13450

Merged
Lyokone merged 2 commits intomainfrom
mtewani/fix-nativefromjson-2
Oct 3, 2024
Merged

fix(fdc): Fix serializing errors#13450
Lyokone merged 2 commits intomainfrom
mtewani/fix-nativefromjson-2

Conversation

@maneesht
Copy link
Copy Markdown
Contributor

@maneesht maneesht commented Oct 1, 2024

  • Fix issue where on GRPC, since protobuf doesn't distinguish between double and int, all numbers were being parsed as doubles.
  • Fix issue where execute.ignore was called, causing errors not being thrown.

@Lyokone Lyokone merged commit 9a5aba2 into main Oct 3, 2024
@Lyokone Lyokone deleted the mtewani/fix-nativefromjson-2 branch October 3, 2024 07:48
@firebase firebase locked and limited conversation to collaborators Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants