Conversation
cfdc62e to
590467d
Compare
36b86a6 to
eb46364
Compare
|
Hello @Lyokone, thank you for creating this PR! I tested it out and encountered an issue with phone number authentication: After some investigation, I found that changing line 103 of packages/firebase_auth/firebase_auth_web/lib/src/firebase_auth_web_recaptcha_verifier_factory.dart to this resolved the issue for me: _delegate = auth_interop.RecaptchaVerifier(
- element,
+ element.toJS,
parameters,
auth.delegate,
);Would you be open to including this fix in your PR? This would help me depend on it directly. |
|
@mj-shifu thanks so much for noticing 👍 We have some dynamic left here and there from the first implementation 😓 I've pushed the fix |
|
latest version should be used |
|
How long does it take for this update to be released and available on pub.dev? |
|
I would love this to be merged as well. This dependency is blocking quite some of my other dependencies |
|
@russellwheatley @Salakar this PR unblocks a train of dependency updates that grows longer by the day.... |
|
@russellwheatley @Salakar please review this PR asap. A lot of depedencies are being blocked by this. Thank you. |
|
@Lyokone This Did not work for me... The latter command failed. |
|
Also, side question: I am actually not using flutter on web, so I was wondering if there was a way to prevent this dependency to be used altogether from my project |
|
@millerf Unfortunately, the web package was in beta, but it is now stable 1.0.0, it will have less frequent updates or breaking changes |
|
Hello, this PR has attracted a lot of attention. We are not ready to force users to upgrade to Dart 3.4 (which is required for us to add support for |
|
@Lyokone getting some typeerrors in The AndroidSettings and IOSSettings fields are not being converted to JS. This works: PR here: #13260 |
|
@Lyokone pls release an update with this PR asap. A lot of packages are stuck only because of this |
The existing package is not compatible with web^1.0.0 so it won't overwrite as well |
|
Nice! Thanks for working on it everyone! Will it be deployed on |
|
It is now deployed. |
Description
If you want to use this PR early, you can use latest version of FlutterFire CLI
Related Issues
closes #13190
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?