fix(storage): do not set metadata property unless it has a value#12805
Merged
russellwheatley merged 6 commits intomasterfrom May 22, 2024
Merged
fix(storage): do not set metadata property unless it has a value#12805russellwheatley merged 6 commits intomasterfrom
russellwheatley merged 6 commits intomasterfrom
Conversation
Lyokone
approved these changes
May 22, 2024
TarekkMA
approved these changes
May 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes a bug where if we set one property on
SettableMetadata(e.g.customMetadata), it would also set every other metadata property tonull. This was stoppingcontentTypefrom being inferred for android at least.Unfortunately, the emulator doesn't infer
contentType, so I tested on a live project and it is now inferring type if SettableMetadata is used without settingcontentType.Related Issues
fixes #12801
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?