fix(core, web): More explicit interop types (#17809)

MichaelVerdon · web-flow · commit 795567a64f20 · 2025-10-24T10:24:53.000+01:00
diff --git a/packages/firebase_core/firebase_core_web/lib/src/interop/app_interop.dart b/packages/firebase_core/firebase_core_web/lib/src/interop/app_interop.dart
@@ -12,11 +12,7 @@ import 'dart:js_interop';
 
 import 'core_interop.dart';
 
-@JS('FirebaseApp')
-@staticInterop
-abstract class AppJsImpl {}
-
-extension AppJsImplExtension on AppJsImpl {
+extension type AppJsImpl._(JSObject _) implements JSObject {
   external JSString get name;
   external FirebaseOptions get options;
 }
diff --git a/packages/firebase_core/firebase_core_web/lib/src/interop/core_interop.dart b/packages/firebase_core/firebase_core_web/lib/src/interop/core_interop.dart
@@ -13,8 +13,7 @@ import 'dart:js_interop';
 import 'package:firebase_core_web/firebase_core_web_interop.dart';
 
 @JS()
-// List<AppJsImpl>
-external JSArray getApps();
+external JSArray<AppJsImpl> getApps();
 
 /// The current SDK version.
 ///
@@ -42,12 +41,7 @@ external void registerVersion(
 /// In addition to a message string, it contains a string-valued code.
 ///
 /// See: <https://firebase.google.com/docs/reference/js/firebase.FirebaseError>.
-@JS('FirebaseError')
-@anonymous
-@staticInterop
-abstract class FirebaseErrorJSImpl {}
-
-extension FirebaseErrorExtension on FirebaseErrorJSImpl {
+extension type FirebaseErrorJsImpl._(JSObject _) implements JSObject {
   external JSString get code;
   external JSString get message;
   external JSString get name;
@@ -58,10 +52,7 @@ extension FirebaseErrorExtension on FirebaseErrorJSImpl {
 }
 
 /// A structure for options provided to Firebase.
-@JS()
-@anonymous
-@staticInterop
-class FirebaseOptions {
+extension type FirebaseOptions._(JSObject _) implements JSObject {
   external factory FirebaseOptions({
     JSString? apiKey,
     JSString? authDomain,
