feat(storage, windows): add support for creationTime and updateTime (#12966)

Lyokone · web-flow · commit 70a3fbc97ec3 · 2024-06-19T14:43:27.000+02:00
* feat(storage, windows): add support for creationTime and updateTime

* format
diff --git a/packages/firebase_storage/firebase_storage/example/windows/flutter/CMakeLists.txt b/packages/firebase_storage/firebase_storage/example/windows/flutter/CMakeLists.txt
@@ -10,6 +10,11 @@ include(${EPHEMERAL_DIR}/generated_config.cmake)
 # https://github.com/flutter/flutter/issues/57146.
 set(WRAPPER_ROOT "${EPHEMERAL_DIR}/cpp_client_wrapper")
 
+# Set fallback configurations for older versions of the flutter tool.
+if (NOT DEFINED FLUTTER_TARGET_PLATFORM)
+  set(FLUTTER_TARGET_PLATFORM "windows-x64")
+endif()
+
 # === Flutter Library ===
 set(FLUTTER_LIBRARY "${EPHEMERAL_DIR}/flutter_windows.dll")
 
@@ -92,7 +97,7 @@ add_custom_command(
   COMMAND ${CMAKE_COMMAND} -E env
     ${FLUTTER_TOOL_ENVIRONMENT}
     "${FLUTTER_ROOT}/packages/flutter_tools/bin/tool_backend.bat"
-      windows-x64 $<CONFIG>
+      ${FLUTTER_TARGET_PLATFORM} $<CONFIG>
   VERBATIM
 )
 add_custom_target(flutter_assemble DEPENDS
diff --git a/packages/firebase_storage/firebase_storage/windows/firebase_storage_plugin.cpp b/packages/firebase_storage/firebase_storage/windows/firebase_storage_plugin.cpp
@@ -393,6 +393,8 @@ std::string kCustomMetadataName = "customMetadata";
 std::string kMetadataName = "metadata";
 std::string kSizeName = "size";
 std::string kBucketName = "bucket";
+std::string kCreationTimeMillisName = "creationTimeMillis";
+std::string kUpdatedTimeMillisName = "updatedTimeMillis";
 
 flutter::EncodableMap ConvertMedadataToPigeon(const Metadata* meta) {
   flutter::EncodableMap meta_map = flutter::EncodableMap();
@@ -430,6 +432,12 @@ flutter::EncodableMap ConvertMedadataToPigeon(const Metadata* meta) {
     }
     meta_map[flutter::EncodableValue(kCustomMetadataName)] = custom_meta_map;
   }
+  meta_map[flutter::EncodableValue(kCreationTimeMillisName)] =
+      flutter::EncodableValue(meta->creation_time());
+
+  meta_map[flutter::EncodableValue(kUpdatedTimeMillisName)] =
+      flutter::EncodableValue(meta->updated_time());
+
   return meta_map;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -393,6 +393,8 @@ std::string kCustomMetadataName = "customMetadata";`
`393`	`393`	`std::string kMetadataName = "metadata";`
`394`	`394`	`std::string kSizeName = "size";`
`395`	`395`	`std::string kBucketName = "bucket";`
	`396`	`+std::string kCreationTimeMillisName = "creationTimeMillis";`
	`397`	`+std::string kUpdatedTimeMillisName = "updatedTimeMillis";`
`396`	`398`
`397`	`399`	`flutter::EncodableMap ConvertMedadataToPigeon(const Metadata* meta) {`
`398`	`400`	`flutter::EncodableMap meta_map = flutter::EncodableMap();`
`@@ -430,6 +432,12 @@ flutter::EncodableMap ConvertMedadataToPigeon(const Metadata* meta) {`
`430`	`432`	`}`
`431`	`433`	`meta_map[flutter::EncodableValue(kCustomMetadataName)] = custom_meta_map;`
`432`	`434`	`}`
	`435`	`+ meta_map[flutter::EncodableValue(kCreationTimeMillisName)] =`
	`436`	`+ flutter::EncodableValue(meta->creation_time());`
	`437`	`+`
	`438`	`+ meta_map[flutter::EncodableValue(kUpdatedTimeMillisName)] =`
	`439`	`+ flutter::EncodableValue(meta->updated_time());`
	`440`	`+`
`433`	`441`	`return meta_map;`
`434`	`442`	`}`
`435`	`443`