[FDC] init dataconnect:sdk use consistent gen SDK package names#9021
Merged
[FDC] init dataconnect:sdk use consistent gen SDK package names#9021
init dataconnect:sdk use consistent gen SDK package names#9021Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
307dd6a to
ae40fae
Compare
init dataconnect:sdk should generate consistent hard-coded package name init dataconnect:sdk use consistent gen SDK package names
maneesht
approved these changes
Aug 21, 2025
Contributor
maneesht
left a comment
There was a problem hiding this comment.
LGTM, but can you update the tests?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9021 +/- ##
==========================================
+ Coverage 49.55% 49.62% +0.07%
==========================================
Files 673 673
Lines 38477 38515 +38
Branches 7676 7662 -14
==========================================
+ Hits 19066 19114 +48
+ Misses 17879 17864 -15
- Partials 1532 1537 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Scenarios Tested
Sample Commands