Skip to content

Fix service_location not passed to dataconnect binary.#7217

Merged
yuchenshi merged 2 commits intomasterfrom
ys/fdc-service-location-arg
May 24, 2024
Merged

Fix service_location not passed to dataconnect binary.#7217
yuchenshi merged 2 commits intomasterfrom
ys/fdc-service-location-arg

Conversation

@yuchenshi
Copy link
Copy Markdown
Member

Description

See title

Scenarios Tested

Ran firebase emulators:start locally and looked at pgrep -a dataconnect full command line to make sure the argument gets passed

Sample Commands

@yuchenshi yuchenshi enabled auto-merge (squash) May 24, 2024 01:12
@yuchenshi yuchenshi merged commit 45a5718 into master May 24, 2024
@yuchenshi yuchenshi deleted the ys/fdc-service-location-arg branch May 24, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants