Code to create emulators.yaml uses backend root not project root (#8412)

inlined · joehan · web-flow · commit f8eab0b17ce4 · 2025-05-01T16:02:51.000Z
* Use backend root, not project root to initilaize apphosting.emulators.yaml

* Changelog &amp; lint

* Update CHANGELOG.md

Co-authored-by: joehan &lt;joehanley@google.com&gt;

---------

Co-authored-by: joehan &lt;joehanley@google.com&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1 +1 @@
-- Upgraded `inquirer` library to address some visual bugs with prompting (#8389)
+- Fixed an issue where the prompt to create apphosting.emulator.yaml did not work with backends that are not at the project.root (#8412)
diff --git a/src/apphosting/config.ts b/src/apphosting/config.ts
@@ -218,11 +218,11 @@ export async function maybeAddSecretToYaml(
  */
 export async function maybeGenerateEmulatorYaml(
   projectId: string | undefined,
-  repoRoot: string,
+  backendRoot: string,
 ): Promise<Env[] | null> {
   // Even if the app is in /project/app, the user might have their apphosting.yaml file in /project/apphosting.yaml.
   // Walk up the tree to see if we find other local files so that we can put apphosting.emulator.yaml in the right place.
-  const basePath = dynamicDispatch.discoverBackendRoot(repoRoot) || repoRoot;
+  const basePath = dynamicDispatch.discoverBackendRoot(backendRoot) || backendRoot;
   if (fs.fileExistsSync(join(basePath, APPHOSTING_EMULATORS_YAML_FILE))) {
     logger.debug(
       "apphosting.emulator.yaml already exists, skipping generation and secrets access prompt",
diff --git a/src/emulator/initEmulators.ts b/src/emulator/initEmulators.ts
@@ -7,7 +7,6 @@ import { detectStartCommand } from "./apphosting/developmentServer";
 import { EmulatorLogger } from "./emulatorLogger";
 import { Emulators } from "./types";
 import { Env, maybeGenerateEmulatorYaml } from "../apphosting/config";
-import { detectProjectRoot } from "../detectProjectRoot";
 import { Config } from "../config";
 import { getProjectId } from "../projectUtils";
 import { grantEmailsSecretAccess } from "../apphosting/secrets";
@@ -42,8 +41,7 @@ export const AdditionalInitFns: AdditionalInitFnsType = {
     const projectId = getProjectId(config.options);
     let env: Env[] | null = [];
     try {
-      const projectRoot = detectProjectRoot({ cwd: config.options.cwd }) ?? backendRoot;
-      env = await maybeGenerateEmulatorYaml(projectId, projectRoot);
+      env = await maybeGenerateEmulatorYaml(projectId, backendRoot);
     } catch (e) {
       logger.log("WARN", "failed to export app hosting configs");
     }

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		-- Upgraded `inquirer` library to address some visual bugs with prompting (#8389)
	`1`	`+- Fixed an issue where the prompt to create apphosting.emulator.yaml did not work with backends that are not at the project.root (#8412)`