Skip to content

Commit f5671f1

Browse files
authored
Fix firebase-vscode/package-lock.json and add it to linting. (#5965)
* Fix firebase-vscode/package-lock.json and add it to linting. * Update node-test.yml
1 parent 628aa75 commit f5671f1

2 files changed

Lines changed: 42 additions & 53 deletions

File tree

.github/workflows/node-test.yml

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,13 +192,30 @@ jobs:
192192
uses: actions/setup-node@v3
193193
with:
194194
node-version: ${{ matrix.node-version }}
195-
cache: npm
196-
cache-dependency-path: npm-shrinkwrap.json
197195
- run: npm i -g npm@9.5
198196
# --ignore-scripts prevents the `prepare` script from being run.
199197
- run: npm install --package-lock-only --ignore-scripts
200198
- run: "git diff --exit-code -- npm-shrinkwrap.json || (echo 'Error: npm-shrinkwrap.json is changed during npm install! Please make sure to use npm >= 8 and commit npm-shrinkwrap.json.' && false)"
201199

200+
check-package-lock-vsce:
201+
runs-on: ubuntu-latest
202+
203+
strategy:
204+
matrix:
205+
node-version:
206+
- "18"
207+
208+
steps:
209+
- uses: actions/checkout@v3
210+
- name: Use Node.js ${{ matrix.node-version }}
211+
uses: actions/setup-node@v3
212+
with:
213+
node-version: ${{ matrix.node-version }}
214+
- run: npm i -g npm@9.5
215+
# --ignore-scripts prevents the `prepare` script from being run.
216+
- run: "(cd firebase-vscode && npm install --package-lock-only --ignore-scripts)"
217+
- run: "git diff --exit-code -- firebase-vscode/package-lock.json || (echo 'Error: firebase-vscode/package-lock.json is changed during npm install! Please make sure to use npm >= 8 and commit firebase-vscode/package-lock.json.' && false)"
218+
202219
check-json-schema:
203220
runs-on: ubuntu-latest
204221

firebase-vscode/package-lock.json

Lines changed: 23 additions & 51 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)