Gracefully handle appdistribution:testers:list returning no testers (#8349)

kaibolay · web-flow · commit ee2e8b5de9f6 · 2025-03-20T18:46:22.000-04:00
diff --git a/src/appdistribution/client.spec.ts b/src/appdistribution/client.spec.ts
@@ -169,6 +169,15 @@ describe("distribution", () => {
       });
       expect(nock.isDone()).to.be.true;
     });
+
+    it("should gracefully handle no testers", async () => {
+      nock(appDistributionOrigin()).get(`/v1/${projectName}/testers`).reply(200, {});
+
+      await expect(appDistributionClient.listTesters(projectName)).to.eventually.deep.eq({
+        testers: [],
+      });
+      expect(nock.isDone()).to.be.true;
+    });
   });
 
   describe("uploadRelease", () => {
diff --git a/src/appdistribution/client.ts b/src/appdistribution/client.ts
@@ -152,7 +152,7 @@ export class AppDistributionClient {
         throw new FirebaseError(`Client request failed to list testers ${err}`);
       }
 
-      for (const t of apiResponse.body.testers) {
+      for (const t of apiResponse.body.testers ?? []) {
         listTestersResponse.testers.push({
           name: t.name,
           displayName: t.displayName,
@@ -212,7 +212,7 @@ export class AppDistributionClient {
         const apiResponse = await client.get<ListGroupsResponse>(`${projectName}/groups`, {
           queryParams,
         });
-        listGroupsResponse.groups.push(...(apiResponse.body.groups || []));
+        listGroupsResponse.groups.push(...(apiResponse.body.groups ?? []));
         pageToken = apiResponse.body.nextPageToken;
       } catch (err) {
         throw new FirebaseError(`Client failed to list groups ${err}`);
